Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hitscan visuals #34515

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ElectroJr
Copy link
Member

@ElectroJr ElectroJr commented Jan 19, 2025

About the PR

Fixes hitscan visuals when shooting across grids.

Technical details

This PR just makes sure that the angle passed in the event is always relative to the entity associated with the fromCoordinate, and makes sure that all the parts of the beam have the same world rotation.

I finished this PR after fixing #34482, but before realising that there is already an open PR that also tries to fix this (#28797), though it's been stuck waiting on an engine PR that was waiting for reviews/responses. I'm not sure about the required engine changes and think a better fix would be to just combine the laser effect into a singular entity (which this neither PR does).

In the meantime, this PR still fixes the main issue w/o requiring any engine changes, though it doesn't fix the problem that the beam can split when grids move or rotate.

fixes #23699

Media

Before: see video in #5365

After:

Content.Client_EnDBPw28Yi.mp4

Requirements

Changelog

IMO @n00kii still deserves the credit for initially working on a fix for this bug, but if they don't want their name on the CL I can remove it

🆑 n00kii

  • fix: Fixed laser weapon visuals being broken when shooting across grids or into space.

@ElectroJr ElectroJr added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. labels Jan 19, 2025
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. labels Jan 19, 2025
@ScarKy0 ScarKy0 added D3: Low Difficulty: Some codebase knowledge required. A: Combat Area: Combat features and changes, balancing, feel and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Combat Area: Combat features and changes, balancing, feel D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange laser visual behaviour in open space
2 participants