Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed minor spelling mistake in Noir Trenchcoat description. #34519

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Fixed minor spelling mistake in Noir Trenchcoat description. #34519

merged 1 commit into from
Jan 19, 2025

Conversation

Tezzaide
Copy link
Contributor

About the PR

Fixed a minor spelling mistake

Why / Balance

Technical details

Media

Requirements

Breaking changes

Changelog

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 19, 2025
@ScarKy0 ScarKy0 added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 19, 2025
Aeshus
Aeshus approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ScarKy0
Copy link
Contributor

ScarKy0 commented Jan 19, 2025

Thanks for the PR!

Dont you dare steal the merge from me >:(

@Aeshus
Copy link
Contributor

Aeshus commented Jan 19, 2025

Thanks for the PR!

Dont you dare steal the merge from me >:(

Then merge it first ',:-|

@ScarKy0
Copy link
Contributor

ScarKy0 commented Jan 19, 2025

Then merge it first ',:-|

Waiting for tests :godo:

ScarKy0
ScarKy0 approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thank you for your first contribution!

@ScarKy0 ScarKy0 merged commit a83fd7b into space-wizards:master Jan 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScarKy0 ScarKy0 ScarKy0 approved these changes

@Aeshus Aeshus Aeshus approved these changes

Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tezzaide @ScarKy0 @Aeshus