Componentize Rat King "Rummaging."

[widgetbeck]

About the PR

Separated out the "rummage" verb and its associated systems from the Rat King component. Also added several options to make it more flexible for developer use.

Why / Balance

Many older components (e.g. Rat King, Dragon, Drone) combine several unrelated systems into one monolithic component with very little YML customizability, which I feel goes against one of the core aims of an ECS - modularity.
My goal in my next few upstream PRs is to separate out these (niche, but useful) mechanics so that they can be more easily used by developers without having to develop their own systems that do the same thing, and in so doing provide more variables which can be manipulated without delving into CS.

Technical details

In this PR, I:

• Create two new components, CanRummage and Rummageable, which replace the same parts of Rat King component.
• Create a new system, RummagingSystem, which performs the functions previously confined to Rat King component.
• Add several options to CanRummage, including:
  • The ability to define a default rummage loot table per-Rummager, as opposed to per-Rummageable object - this can be overridden on the Rummageable object.
  • The ability to customize the LocId of the verb.
  • A rummage speed modifier.
• Add several options to Rummageable, including:
  • The ability to mark a Rummageable entity as "re-lootable", and a definable cooldown for when its loot will be reset.
  • The ability to override the default loot table defined in Rummaging.

Media

Requirements

• [ X ] I have read and am following the Pull Request and Changelog Guidelines.
• [ X ] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

I have not included a changelog because these changes do not immediately affect gameplay.

[iaada]

I like this PR! Here's a few things I noticed that I've gotten feedback on before.

[beck-thompson]

Only other thing is, could you rename Rummagningcomponent/system to something like "CanRummage" or something? It was kind of confusing at first!

[beck-thompson]

Just really minor stuff! Doing some final tests now

[widgetbeck]

Your way is cleaner I reckon.

…

On Fri, Jan 31, 2025, 22:47 beck-thompson ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Content.Shared/Rummaging/RummagingSystem.cs <#34530 (comment)> : > + } + + if (!entity.Comp.Looted) + entity.Comp.Looted = true; + + // and set the next refresh if the entity is relootable. + if (entity.Comp.Relootable) + entity.Comp.NextRelootable = _gameTiming.CurTime + entity.Comp.RelootableCooldown; + } + + // checks Relootable status + public bool IsCurrentlyLootable(Entity<RummageableComponent> entity) + { + if (entity.Comp.Relootable) + { + if (entity.Comp.NextRelootable < _gameTiming.CurTime) The only one that I found confusing is the second if statement. If you want to keep the first one that would make sense! — Reply to this email directly, view it on GitHub <#34530 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BG6OZJEIYMNE5QNC7UYI6P32NQ7VXAVCNFSM6AAAAABVPROXM2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBYGIZDQNJUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>