Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new cool shield to warden so he finally has something lol #34610

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

minthydra
Copy link

@minthydra minthydra commented Jan 23, 2025

About the PR

  • Added a new general purpose shield for warden

Why / Balance

In general I mostly added it because its cool, as well as the fact hos has a fancy energy shotgun but warden gets nothing.
Warden has always been much more defensive when compared to hos, his armor already reflects that so I thought he could get a shield too.

The shield has all around mediocre stats against all damage types, a jack of all trades sorta deal.

The shield can also be repaired so that warden doesn't immediately loose his shield on his first fight.
To balance this the shield needs a repair time of 20 seconds and takes 50 fuel so it cant just be repaired mid fight.

Technical details

Basically just a copy of the eshield code with added functionality to repair it.

Media

https://youtu.be/jCmKsVxs3t8?si=j6K3nf79_GEuP8Kf
shield2
shield1

Requirements

Breaking changes

Changelog

🆑

  • Adds the ceremonial shield for warden

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/M Denotes a PR that changes 100-999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

RSI Diff Bot; head commit 0570f40 merging into b248921
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Melee/wardenshield.rsi

State Old New Status
inhand-left-shield Added
inhand-right-shield Added
wardenshield-icon Added
wardenshield-inhand-left Added
wardenshield-inhand-right Added
wardenshield-on Added

Edit: diff updated after 0570f40

@Killerqu00
Copy link
Contributor

maybe make it restricted to warden specifically?

@minthydra
Copy link
Author

maybe make it restricted to warden specifically?

There is only ever one that spawns and its in his locker.
unless you mean contraband markers?

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content S: Needs Review Status: Requires additional reviews before being fully accepted T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Combat Area: Combat features and changes, balancing, feel A: Security Area: Security department, including Detectives, HoS labels Jan 23, 2025
@FairlySadPanda
Copy link
Contributor

FairlySadPanda commented Jan 23, 2025

I like the idea, so the main question I'd have is how much better is this shield implementation versus the Warden just grabbing a shield from the normal sec supply? If it's noticeably better, it makes it hard to justify the Warden holding onto it when the HOS is a far more likely target for Nukies, Revs, II, etc.

This is a bit like the Cap's Sabre where "the Cap should absolutely have something super cool" has to be balanced.

Given this is a unique item, this would be a great Thief objective.

@ps3moira
Copy link
Contributor

ps3moira commented Jan 23, 2025

Not sure if this should be added and warden's be given this considering they're not supposed to be a combat focused role and the fact they have the entire armory at their disposal.

@minthydra
Copy link
Author

Not sure if this should be added and warden's be given this considering they're not supposed to be a combat focused role and the fact they have the entire armory at their disposal.

I wanted it to be something unique warden can have that suits him being defensive.
Its mainly "intended" for use in something like an armory breach or revs/zombies attacking sec.

@FairlySadPanda
Copy link
Contributor

FairlySadPanda commented Jan 23, 2025

@ps3moira I think this can be resolved by making sure this shield is only slightly better than the normal Sec supply? It absolutely makes sense for the Warden to have a shield as a mark of rank, and more unique job items mapped means more for Thief antags to steal. Det revolver, HOS shotgun, Warden shield.

@minthydra
Copy link
Author

minthydra commented Jan 23, 2025

I like the idea, so the main question I'd have is how much better is this shield implementation versus the Warden just grabbing a shield from the normal sec supply? If it's noticeably better, it makes it hard to justify the Warden holding onto it when the HOS is a far more likely target for Nukies, Revs, II, etc.

The shield is only slightly better than sec supply, in terms of stats it has overall worse protection than every other shield with the fact it has protection against everything and the ability for it to be repaired making up for it.
atleast thats whats intended lol.
theres a video showing its performance in media.

@FairlySadPanda
Copy link
Contributor

OK, balance is subjective (you could just hella nerf the stats to get it over the line and say it's ceremonial, lmao) so I'll do a quick review ignoring balance implications

@walksanatora
Copy link

also I think you mispelled derived instead of dirived in the item description

Resources/Prototypes/Entities/Objects/Shields/shields.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Objects/Shields/shields.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Objects/Shields/shields.yml Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need artmin review but atm it's a tad plain, I think. It's the Warden's special shield. It should have like, the Sec symbol painted on it or something.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers for the feedback so far i basically copied your description fluff since i liked it so much if you dont mind.
I may touch up the sprites if not someone else is more than welcome to!

@minthydra
Copy link
Author

also I think you mispelled derived instead of dirived in the item description

I did lol, its fixed in the actual code

@ArtisticRoomba
Copy link
Contributor

Like others have said, it would be ideal if this had marginally better stats to encourage its usage.

In my opinion, I don't think the warden needs a shield, but if you could make it so that the stats of the item are to encourage defense instead of offense, I think it could be a good addition.

@ps3moira
Copy link
Contributor

ps3moira commented Jan 23, 2025

Like others have said, it would be ideal if this had marginally better stats to encourage its usage.

In my opinion, I don't think the warden needs a shield, but if you could make it so that the stats of the item are to encourage defense instead of offense, I think it could be a good addition.

I agree on that point that not every role should get a unique item as to reduce bloat content

@minthydra
Copy link
Author

Like others have said, it would be ideal if this had marginally better stats to encourage its usage.

In my opinion, I don't think the warden needs a shield, but if you could make it so that the stats of the item are to encourage defense instead of offense, I think it could be a good addition.

the stats are generally marginally better yes, with the fact it can be repaired but taking a while to repair, as well as belonging to warden making it defensive.

@minthydra
Copy link
Author

Like others have said, it would be ideal if this had marginally better stats to encourage its usage.
In my opinion, I don't think the warden needs a shield, but if you could make it so that the stats of the item are to encourage defense instead of offense, I think it could be a good addition.

I agree on that point that not every role should get a unique item as to reduce bloat content

I do generally agree with you on that, but in general ward has nothing that separates him from other secoffs, (other than a literally worse hardsuit).
In terms of bloat content aswell wizden isnt that bloated compared to something like goob, i just think it would be a cool fun addition even if not used much.

@walksanatora
Copy link

also I kinda like all the other head items. I kinda want it to be a valid theif/traitor objective.

@ArtisticRoomba
Copy link
Contributor

as well as belonging to warden making it defensive.

Just because it belongs to the warden doesn't mean it's defensive. Mechanically it should have stats encouraging holding a position, not advancing on one. A slowdown for example.

@minthydra
Copy link
Author

as well as belonging to warden making it defensive.

Just because it belongs to the warden doesn't mean it's defensive. Mechanically it should have stats encouraging holding a position, not advancing on one. A slowdown for example.

that's true a slowdown could be added, though I think ward is already slow enough with his armor.
maybe making the base stats slightly worse but defensive position better?

@minthydra
Copy link
Author

also I kinda like all the other head items. I kinda want it to be a valid theif/traitor objective.

I did actually think about that, I may add that now.

@ArtisticRoomba
Copy link
Contributor

I do generally agree with you on that, but in general ward has nothing that separates him from other secoffs, (other than a literally worse hardsuit).

Warden has:

  • The ability to access the armory
  • Armor almost on par with the HoS
  • Authority over all other security officers second to the HoS
  • The armory door remote
  • Preferred person to sentence and keep watch over criminals
  • Etc.

@minthydra
Copy link
Author

I do generally agree with you on that, but in general ward has nothing that separates him from other secoffs, (other than a literally worse hardsuit).

Warden has:

  • The ability to access the armory
  • Armor almost on par with the HoS
  • Authority over all other security officers second to the HoS
  • The armory door remote
  • Preferred person to sentence and keep watch over criminals
  • Etc.

I mean yeah thats all true, idk actually playing as ward doesn't feel that fun and having him have a shield could be nice is all I'm saying :( .

@lzk228
Copy link
Contributor

lzk228 commented Jan 23, 2025

your cl is broken
🆑 symbol is missing

@minthydra
Copy link
Author

your cl is broken 🆑 symbol is missing

cheers sorry im still new to this lol

@Everturning
Copy link

i dont think the warden needs this personally

Also your CL is what the players see in the ChangeLog, so you just need to do something like

"Adds the Ceremonial Shield for the warden."

@minthydra
Copy link
Author

i dont think the warden needs this personally

Also your CL is what the players see in the ChangeLog, so you just need to do something like

"Adds the Ceremonial Shield for the warden."

ah gotcha cheers

@KaiserMaus
Copy link

Better add warden sawn-kammer for 1x3 size

@Killerqu00
Copy link
Contributor

maybe make it restricted to warden specifically?

There is only ever one that spawns and its in his locker. unless you mean contraband markers?

yeah that
would be lame if it was yet another captain ID card that gets passed around, being in every person's hands except the person who's actually supposed to have it

@kosticia
Copy link
Contributor

Not sure that we need add more shields while they are so much useless in combat

@minthydra
Copy link
Author

Not sure that we need add more shields while they are so much useless in combat

I don’t know shields are pretty op they literally block half your damage, a hos with the mp7 and a bullet shield can more or less 1 v 1 or even 1 v 2 a nukie.

@minthydra
Copy link
Author

maybe make it restricted to warden specifically?

There is only ever one that spawns and its in his locker. unless you mean contraband markers?

yeah that would be lame if it was yet another captain ID card that gets passed around, being in every person's hands except the person who's actually supposed to have it

Unfortunately there aren’t specific job title contraband’s the most I could do was add it to ward locker as well as a slow to discourage anyone else from using it.

@Nox38
Copy link
Contributor

Nox38 commented Jan 24, 2025

I love that the warden is getting some love, but I have a few issues with this:

  • Why is it called the cermonial shield, if it serves a very practical purpose?
  • Energy shield tech has been restricted to the syndicate so far, feels weird for warden to suddenly have one.
  • The warden doesn't have access to any one handed weapons besides the Mk58, so I can't see them actually using this shield unless the HoS gives them the WT550.

@KaiserMaus
Copy link

I think better add that shield to high research tech

@LaCumbiaDelCoronavirus
Copy link

  • The warden doesn't have access to any one handed weapons besides the Mk58, so I can't see them actually using this shield unless the HoS gives them the WT550.

Most two-handed guns (lecter, drozd) can usually still be used one-handed while still being effective at close-range. Especially the drozd, which is still good in combat while unwielded, even if your target is outside of close-range. The Mk58 can be great too if you're not using it just by itself.

This also doesn't include one-handed melee weapons such as knives, stun batons and truncheons, with all three being usually very effective paired with any sort of shield (ofcourse in situations where they make sense to use, e.g. not when bringing a baton and shield against someone with a gun)

Unrelated to reply: what is basically a free, round-start telescopic shield for the warden sounds cool.

@Warpzoned
Copy link

Warpzoned commented Jan 25, 2025

I really like the idea! But I do have some issues/questions I'd like to point out.

Theme - Why is it an energy-based shield? Would this not go more in-line with Nuclear Operatives rather than the Warden? Why should the Warden even get a unique item possibly on-par with Command's whilst not being part of Command themselves?

Balancing - As others have pointed out, it's not imminently better than any other armory shield, however, I think to supplement this (And to add onto how Warden should be a "defensive" role) you could make it so that:

  • It regenerates when damaged, similarly to other "special" gadgets (ie. EShotty, Cap's laser)
  • Blocking SUBSTANTIALLY increases its stats

Both of the above, IMHO, would greatly incentivize attrition, hence making the shield a more "defensive" tool!

@Pumkin69
Copy link

Pumkin69 commented Feb 1, 2025

I think this is really cool but don't wanna see HoS's running around with a wt-550, this shield and an energy shotgun. I think it should be good but not insanely strong and i think it should be able to recharge its health when it breaks either through a recharger or self charging. Really cool idea and it makes sense as warden is gonna be the front line for antags breaking into armory so it makes sense they would get a shield.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Combat Area: Combat features and changes, balancing, feel A: Security Area: Security department, including Detectives, HoS Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.