Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename shields #34794

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Rename shields #34794

merged 4 commits into from
Jan 31, 2025

Conversation

Nox38
Copy link
Contributor

@Nox38 Nox38 commented Jan 31, 2025 •
edited
Loading

About the PR

Renamed riot bullet shield to ballistic shield, renamed riot laser shield to ablative shield, changed descriptions.

Why / Balance

The old names were clunky and not very descriptive.

Technical details

Changed name and description in shields.yml

Media

image
image

Requirements

Changelog
🆑 Nox38

  • tweak: Renamed riot bullet shield to ballistic shield
  • tweak: Renamed riot laser shield to ablative shield

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Jan 31, 2025
@Nox38 Nox38 changed the title Rename "Riot Bullet Shield" to Ballistic Shield Rename shields Jan 31, 2025
@Nox38 Nox38 marked this pull request as ready for review January 31, 2025 18:54
@Kinar7
Copy link

Kinar7 commented Jan 31, 2025

I like more realistic names

@KaiserMaus
Copy link

Why shields don't have small reflect chance?
10-15% will make shield more durable and more useful
Player pay one hand for only few shots before shield broke

@Nox38
Copy link
Contributor Author

Nox38 commented Jan 31, 2025

@KaiserMaus This isnt a PR to rebalance the shields, just to rename them. I agree that the laser shield should reflect lasers but that's outside the scope of this PR

@Nox38 Nox38 requested a review from keronshb January 31, 2025 21:32
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jan 31, 2025
@Nox38
Copy link
Contributor Author

Nox38 commented Jan 31, 2025

@keronshb Added your changes, could you unblock the PR?

keronshb
keronshb approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@keronshb keronshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@keronshb keronshb merged commit 3622518 into space-wizards:master Jan 31, 2025
12 checks passed
@Nox38 Nox38 deleted the Rename-shields branch February 1, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centronias Centronias Centronias left review comments

@keronshb keronshb keronshb approved these changes

Assignees
No one assigned
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nox38 @Kinar7 @KaiserMaus @Centronias @keronshb