Fix screens not being dismantlable #34804
Open
+169
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: No C#
ArtisticRoomba
suggested changes
Feb 1, 2025
There was a problem hiding this comment.
You'll need to attribute your sprites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Added construction steps specific to screens to allow them to be built from scratch and deconstructed completely (fixes #33224) Also added some sprites for the various build steps of the screen (inspiration taken from the existing station map sprites)
Why / Balance
Currently, screens cannot be deconstructed completely. Once they are deconned to the timer, you are unable to proceed. This makes renovations a touch annoying since you are unable to move the screen.
I've been holding a grudge against this fact for a few weeks now.Technical details
All changes are yaml. Only a few sprites were added. I followed the station map yaml as an example to get me to a working setup so there may be some optimization to be had here. I also wanted to have screen boards be printable in a lathe but I've run into a roadblock with getting it to appear in the lathe. I was also curious if there is any concerns with screens generating lag on the server. Not sure if thats even an issue to be worried about but worst case the screen board can be left hidden from the lathe. I did observe what seemed to be some inconsistencies with the yaml for station maps. Those inconsistencies are present here because I wasn't sure if they were intentional or not. (referring to how in one file door_electronics is used and in the next airalarm_electronics is used.) I can of course change this if so desired.
Media
Requirements
Breaking changes
Shouldn't be... I hope?
Changelog
🆑