Lots of nonfunctional clean up of tabletop stuff #34958
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Just code. Updated stuff to modern standards (assuming I know those :^) )
For reviewers, note that there are three commits:
namespace { ... }
usage to filenamespace ...;
usageI suggest looking at each commit individually rather than trying to look at them all layered together.
Why / Balance
I kinda wanna reuse the tabletop stuff for other stuff, so I wanted to clean it up.
Technical details
Lots of small things. I can enumerate them if you want.
The number of lines is because of
namespace { ... }
->namespace ;
changes.Media
N/A
Requirements
Breaking changes
TabletopSetup
is totally changed, but it should be easy to uptake.I think that's the bulk of it.
Changelog
N/A