Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of nonfunctional clean up of tabletop stuff #34958

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Centronias
Copy link
Contributor

@Centronias Centronias commented Feb 7, 2025

About the PR

Just code. Updated stuff to modern standards (assuming I know those :^) )

For reviewers, note that there are three commits:

  • one for moving some files only
  • one for changing from scoped namespace { ... } usage to file namespace ...; usage
  • one for actual implementation changes.

I suggest looking at each commit individually rather than trying to look at them all layered together.

Why / Balance

I kinda wanna reuse the tabletop stuff for other stuff, so I wanted to clean it up.

Technical details

Lots of small things. I can enumerate them if you want.
The number of lines is because of namespace { ... } -> namespace ; changes.

Media

N/A

Requirements

Breaking changes

TabletopSetup is totally changed, but it should be easy to uptake.
I think that's the bulk of it.

Changelog

N/A

@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: UI Changes: Might require knowledge of UI design or code. labels Feb 7, 2025
@lzk228 lzk228 added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: UI Changes: Might require knowledge of UI design or code. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants