Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add In-Hand Sprites to the Snapop Box and Decoy Balloons #34964

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add In-Hand Sprites to the Snapop Box and Decoy Balloons #34964

wants to merge 2 commits into from

Conversation

SeamLesss
Copy link

@SeamLesss SeamLesss commented Feb 8, 2025 •
edited
Loading

About the PR

The Snappop Box and the Decoy Balloon have been given in-hand sprites based on the default box sprite.

Both my first PR and first step to contributing to #33386

Why / Balance

Every other box has the same in-hand sprite, the same should apply to these two.

Technical details

Nothing Special, went off of other PRs that added/modified in-hand sprites.

Media

Screenshot 2025-02-08 143141

Requirements

Changelog

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/S Denotes a PR that changes 10-99 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025 •
edited
Loading

RSI Diff Bot; head commit 36d31b9 merging into d7d77ff
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Fun/toys.rsi

State Old New Status
spbox-inhand-left Added
spbox-inhand-right Added

Resources/Textures/Objects/Tools/Decoys/agent_decoy.rsi

State Old New Status
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Tools/Decoys/commander_decoy.rsi

State Old New Status
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Tools/Decoys/elite_decoy.rsi

State Old New Status
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Tools/Decoys/juggernaut_decoy.rsi

State Old New Status
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Tools/Decoys/operative_decoy.rsi

State Old New Status
inhand-left Added
inhand-right Added

Edit: diff updated after 36d31b9

@lzk228 lzk228 added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. labels Feb 8, 2025
@TiniestShark
Copy link
Contributor

TiniestShark commented Feb 8, 2025 •
edited
Loading

Looks good! More inhands are definitely always a plus. Might be worth seeing if you can add some colored pixels to the centers of the boxes so they stand out individually rather than each of them being relatively similar.

@TiniestShark TiniestShark mentioned this pull request Feb 8, 2025
Open
@SeamLesss
Copy link
Author

I was gonna say something about every box using the default sprite, but then I remembered that these are like 15 pixels large, so I made one for all 6 boxes.

@TiniestShark
Copy link
Contributor

Yee, unless they're all in one folder sharing the same sprite, its better to make sure they're as distinct as possible so people can clearly parse what it is. The colors look much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeamLesss @TiniestShark @lzk228