Lecter + Magazine Resprite #34974
Lecter + Magazine Resprite #34974
Conversation
github-actions
bot
added
Changes: No C#
|
RSI Diff Bot; head commit 7dde473 merging into 87a8684 Resources/Textures/Objects/Weapons/Guns/Ammunition/Magazine/Rifle/rifle_mag.rsi
Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi
|
| "version": 1, | ||
| "license": "CC-BY-SA-3.0", | ||
| "copyright": "All sprites by https://github.com/august-sun.", | ||
| "size": { | ||
| "x": 32, | ||
| "y": 32 | ||
| }, |
There was a problem hiding this comment.
these need to be spaces, our JSON convention is 4-spaced and this file appears to be 4-spaced so do follow it
There was a problem hiding this comment.
@ArtisticRoomba I believe I fixed this?
| }, | ||
| "version": 1, | ||
| "license": "CC-BY-SA-3.0", | ||
| "copyright": "All sprites by https://github.com/august-sun.", |
There was a problem hiding this comment.
minor attribution nitpick but any way you go is fine as long as you give you github username and explicitly say it's github
| "copyright": "All sprites by https://github.com/august-sun.", | |
| "copyright": "All sprites by august-sun (GitHub)", |
| @@ -5,7 +5,7 @@ | |||
| "y": 32 | |||
| }, | |||
| "license": "CC-BY-SA-3.0", | |||
| "copyright": "https://github.com/shiptest-ss13/Shiptest/pull/1602/commits/3e6cfea9d468508a7f64ad5543c3b22479cb465f, https://github.com/shiptest-ss13/Shiptest/blob/master/icons/obj/ammo.dmi", | |||
| "copyright": "All sprites by https://github.com/august-sun.", | |||
There was a problem hiding this comment.
same nitpick here, you can choose to listen to me or not
There was a problem hiding this comment.
When reviewing in rider I just noticed that for some odd and sick and twisted reason that the file formatting on this is so so wrong. I made the changes locally if you'd like to copy them since I can't push to your repo.
{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "All sprites by https://github.com/august-sun.",
"size": {
"x": 32,
"y": 32
},
"states": [There was a problem hiding this comment.
@ArtisticRoomba I think this has been fixed as well!
|
The G36 (looks like it!) my beloved. Good sprites. |
ArtisticRoomba
added
P3: Standard
|
Did you know you can very easily accidentally close your own PR on your phone |
|
looks great, not sure how much the back sprite overlaps with the quiver sprite tho |
|
looks cool |
|
Baller |
|
mag sprites are 🔥 |
| "license": "CC-BY-SA-3.0", | ||
| "copyright": "All sprites by https://github.com/august-sun.", | ||
| "size": { | ||
| "x": 32, | ||
| "y": 32 |
There was a problem hiding this comment.
This is still an issue, I fixed the whitespace on my local:
{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "All sprites by https://github.com/august-sun.",
"size": {
"x": 32,
"y": 32
},
"states": [
|
art approval |
Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi/meta.json
Outdated
Show resolved
Hide resolved
github-actions
bot
added
size/XS
About the PR
Revised the Lecter's sprites, as well as the rifle mag's.
Why / Balance
This respriting gives the Lecter a new design while keeping visual aspects consistent with new security armory sprites.
Technical details
Created new Lecter sprite, with appropriate states (base, icon, mag, wielded left/right, inhand left/right, equipped backpack & suitstorage).
Created new rifle magazine sprite, with appropriate states (base, mag-1, practice, red, uranium).
Media
Requirements
Breaking changes
Changelog
🆑