Default

[dbrgn]

Implement Default for Optional as discussed in #6.

[dbrgn]

I could swear there was once an issue without the namespacing

That was before @dns2utf8 added the use Optional::* line :)

[rnestler]

Removed unneeded namespacing

Can you see it 😉

[rnestler]

Maybe derive it for all spaceapi types as well? Otherwise there is little use for it.

[dbrgn]

Maybe derive it for all spaceapi types as well? Otherwise there is little use for it.

Default for location:

pub struct Location {
    address: Absent,
    lat: 0.0,
    lon: 0.0,
}

The 0.0 doesn't look useful to me. A latitude or longitude does not have a good default.

[rnestler]

Yeah but for some of the types it may be useful.

[dbrgn]

Alright, but we can only implement it for leaf types, not for types that contain other types that don't implement Default.

[dns2utf8]

0.0 / 0.0 is a common default for long / lat, looks ok to me

[dbrgn]

0.0 / 0.0 is a common default for long / lat, looks ok to me

But does it make sense semantically? That location is somewhere in the Gulf of Guinea in the Atlantic Ocean. Does it make sense to default a location to the Gulf of Guinea? I think not.

[rnestler]

You could default it to NaN...

[dns2utf8]

good point

[dbrgn]

We can't override Default for f64. And NaN is not a good default either. A location does not have a good default. NaN would correspond with "no location", which is not valid according to the SpaceAPI. Otherwise we could use an Option.

[rnestler]

However, I think the Default implementation for Optional is OK like that.