Add health check runtime test for memories, fix fram driver and fix internal flash device driver

firmware/app/structs/obdh_data.h

@@ -24,8 +24,9 @@
  * \brief OBDH data structure definition.
  * 
  * \author Gabriel Mariano Marcelino <[email protected]>
+ * \author Carlos Augusto Porto Freitas <[email protected]>
  * 
- * \version 0.10.17
+ * \version 0.10.18
  * 
  * \date 2020/07/16
  * 
@@ -151,20 +152,20 @@ typedef struct
     uint16_t temperature;           /**< Temperature of the uC in Kelvin. */
     uint16_t current;               /**< Input current in mA. */
     uint16_t voltage;               /**< Input voltage in mV. */
-    uint8_t last_reset_cause;       /**< Last reset cause code. */
     uint16_t reset_counter;         /**< Reset counter. */
+    uint8_t last_reset_cause;       /**< Last reset cause code. */
     uint8_t last_valid_tc;          /**< Last valid telecommand ID. */
+    uint8_t mode;                   /**< Satellite mode. */
+    uint8_t ant_deployment_counter; /**< Antenna deployment counter. */
+    uint8_t initial_hib_time_count; /**< Initial hibernation time counter in minutes. */
     uint8_t hw_version;             /**< Hardware version. */
     uint32_t fw_version;            /**< Firmware version (ex.: "v1.2.3" = 0x00010203). */
-    uint8_t mode;                   /**< Satellite mode. */
     sys_time_t ts_last_mode_change; /**< Timestamp of the last change in the operation mode. */
     sys_time_t mode_duration;       /**< Mode duration (valid only in hibernation mode). */
     bool initial_hib_executed;      /**< Initial hibernation executed flag. */
-    uint8_t initial_hib_time_count; /**< Initial hibernation time counter in minutes. */
     bool ant_deployment_executed;   /**< Antenna deployment executed flag. */
-    uint8_t ant_deployment_counter; /**< Antenna deployment counter. */
-    position_data_t position;       /**< Current position of the satellite. */
     media_data_t media;             /**< Memories data. */
+    position_data_t position;       /**< Current position of the satellite. */
 } obdh_data_t;
 
 #endif /* OBDH_DATA_H_ */

firmware/app/tasks/data_log.c

@@ -24,8 +24,9 @@
  * \brief Data log task implementation.
  * 
  * \author Gabriel Mariano Marcelino <[email protected]>
- * 
- * \version 0.10.17
+ * \author Carlos Augusto Porto Freitas <[email protected]>
+ *
+ * \version 0.10.18
  * 
  * \date 2021/05/24
  * 
@@ -34,153 +35,106 @@
  */
 
 #include <stdint.h>
+#include <string.h>
 
 #include <system/sys_log/sys_log.h>
 #include <devices/media/media.h>
 #include <structs/satellite.h>
+#include <utils/mem_mng.h>
 
 #include "data_log.h"
 #include "startup.h"
 
 xTaskHandle xTaskDataLogHandle;
 
-/**
- * \brief Writes data to a given flash memory page.
- *
- * \param[in] is the array of bytes to write.
- *
- * \param[in,out] page is a pointer to the current page to write.
- *
- * \param[in] page_size is the page size, in bytes, of the flash memory.
- *
- * \param[in] start_page is the possible start page to write.
- *
- * \param[in] end_page is the possible end page to write.
- *
- * \return The status/error code.
- */
-int write_data_to_flash_page(uint8_t *data, uint32_t *page, uint32_t page_size, uint32_t start_page, uint32_t end_page);
-
 void vTaskDataLog(void)
 {
     /* Wait startup task to finish */
     xEventGroupWaitBits(task_startup_status, TASK_STARTUP_DONE, pdFALSE, pdTRUE, pdMS_TO_TICKS(TASK_DATA_LOG_INIT_TIMEOUT_MS));
 
     media_info_t nor_info = media_get_info(MEDIA_NOR);
 
-    uint32_t mem_page = 0U;
     uint8_t page_buf[256] = {0};
-    void *null_ptr;
 
     while(1)
     {
         TickType_t last_cycle = xTaskGetTickCount();
 
+        sys_log_print_event_from_module(SYS_LOG_INFO, TASK_DATA_LOG_NAME, "Saving data to flash memory...");
+        sys_log_new_line();
+
         /* OBDH data */
-        if (memcpy(&page_buf[0], &sat_data_buf.obdh, sizeof(obdh_telemetry_t)) == &page_buf[0])
+        (void)memcpy(&page_buf[0], &sat_data_buf.obdh, sizeof(obdh_telemetry_t));
+        if (mem_mng_write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_obdh_data, nor_info.page_size, CONFIG_MEM_OBDH_DATA_START_PAGE, CONFIG_MEM_OBDH_DATA_END_PAGE) != 0)
         {
-            if (write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_obdh_data, nor_info.page_size, CONFIG_MEM_OBDH_DATA_START_PAGE, CONFIG_MEM_OBDH_DATA_END_PAGE) != 0)
-            {
-                sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the OBDH data to the flash memory!");
-                sys_log_new_line();
-            }
+            sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the OBDH data to the flash memory!");
+            sys_log_new_line();
         }
 
-        null_ptr = memset(&page_buf[0], 0, 256);
+        (void)memset(&page_buf[0], 0, 256);
 
         /* EPS data */
-        if (memcpy(&page_buf[0], &sat_data_buf.eps, sizeof(eps_telemetry_t)) == &page_buf[0])
+        (void)memcpy(&page_buf[0], &sat_data_buf.eps, sizeof(eps_telemetry_t));
+        if (mem_mng_write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_eps_data, nor_info.page_size, CONFIG_MEM_EPS_DATA_START_PAGE, CONFIG_MEM_EPS_DATA_END_PAGE) != 0)
         {
-            if (write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_eps_data, nor_info.page_size, CONFIG_MEM_EPS_DATA_START_PAGE, CONFIG_MEM_EPS_DATA_END_PAGE) != 0)
-            {
-                sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the EPS data to the flash memory!");
-                sys_log_new_line();
-            }
+            sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the EPS data to the flash memory!");
+            sys_log_new_line();
         }
 
-        null_ptr = memset(&page_buf[0], 0, 256);
+        (void)memset(&page_buf[0], 0, 256);
 
         /* TTC 0 data */
-        if (memcpy(&page_buf[0], &sat_data_buf.ttc_0, sizeof(ttc_telemetry_t)) == &page_buf[0])
+        (void)memcpy(&page_buf[0], &sat_data_buf.ttc_0, sizeof(ttc_telemetry_t));
+        if (mem_mng_write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_ttc_0_data, nor_info.page_size, CONFIG_MEM_TTC_0_DATA_START_PAGE, CONFIG_MEM_TTC_0_DATA_END_PAGE) != 0)
         {
-            if (write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_ttc_0_data, nor_info.page_size, CONFIG_MEM_TTC_0_DATA_START_PAGE, CONFIG_MEM_TTC_0_DATA_END_PAGE) != 0)
-            {
-                sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the TTC 0 data to the flash memory!");
-                sys_log_new_line();
-            }
+            sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the TTC 0 data to the flash memory!");
+            sys_log_new_line();
         }
 
-        null_ptr = memset(&page_buf[0], 0, 256);
+        (void)memset(&page_buf[0], 0, 256);
 
         /* TTC 1 data */
-        if (memcpy(&page_buf[0], &sat_data_buf.ttc_1, sizeof(ttc_telemetry_t)) == &page_buf[0])
+        (void)memcpy(&page_buf[0], &sat_data_buf.ttc_1, sizeof(ttc_telemetry_t));
+        if (mem_mng_write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_ttc_1_data, nor_info.page_size, CONFIG_MEM_TTC_1_DATA_START_PAGE, CONFIG_MEM_TTC_1_DATA_END_PAGE) != 0)
         {
-            if (write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_ttc_1_data, nor_info.page_size, CONFIG_MEM_TTC_1_DATA_START_PAGE, CONFIG_MEM_TTC_1_DATA_END_PAGE) != 0)
-            {
-                sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the TTC 1 data to the flash emory!");
-                sys_log_new_line();
-            }
+            sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the TTC 1 data to the flash emory!");
+            sys_log_new_line();
         }
 
-        null_ptr = memset(&page_buf[0], 0, 256);
+        (void)memset(&page_buf[0], 0, 256);
 
         /* Antenna data */
-        if (memcpy(&page_buf[0], &sat_data_buf.antenna, sizeof(antenna_telemetry_t)) == &page_buf[0])
+        (void)memcpy(&page_buf[0], &sat_data_buf.antenna, sizeof(antenna_telemetry_t));
+        if (mem_mng_write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_ant_data, nor_info.page_size, CONFIG_MEM_ANT_DATA_START_PAGE, CONFIG_MEM_ANT_DATA_END_PAGE) != 0)
         {
-            if (write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_ant_data, nor_info.page_size, CONFIG_MEM_ANT_DATA_START_PAGE, CONFIG_MEM_ANT_DATA_END_PAGE) != 0)
-            {
-                sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the antenna data to the flash memory!");
-                sys_log_new_line();
-            }
+            sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the antenna data to the flash memory!");
+            sys_log_new_line();
         }
 
-        null_ptr = memset(&page_buf[0], 0, 256);
+        (void)memset(&page_buf[0], 0, 256);
 
         /* EDC data */
-        if (memcpy(&page_buf[0], &sat_data_buf.edc_0, sizeof(payload_telemetry_t)) == &page_buf[0])
+        (void)memcpy(&page_buf[0], &sat_data_buf.edc_0, sizeof(payload_telemetry_t));
+        if (mem_mng_write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_edc_data, nor_info.page_size, CONFIG_MEM_EDC_DATA_START_PAGE, CONFIG_MEM_EDC_DATA_END_PAGE) != 0)
         {
-            if (write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_edc_data, nor_info.page_size, CONFIG_MEM_EDC_DATA_START_PAGE, CONFIG_MEM_EDC_DATA_END_PAGE) != 0)
-            {
-                sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the EDC data to the flash memory!");
-                sys_log_new_line();
-            }
+            sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the EDC data to the flash memory!");
+            sys_log_new_line();
         }
 
-        null_ptr = memset(&page_buf[0], 0, 256);
+        (void)memset(&page_buf[0], 0, 256);
 
         /* Payload-X data */
-        if (memcpy(&page_buf[0], &sat_data_buf.payload_x, sizeof(payload_telemetry_t)) == &page_buf[0])
+        (void)memcpy(&page_buf[0], &sat_data_buf.payload_x, sizeof(payload_telemetry_t));
+        if (mem_mng_write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_px_data, nor_info.page_size, CONFIG_MEM_PX_DATA_START_PAGE, CONFIG_MEM_PX_DATA_END_PAGE) != 0)
         {
-            if (write_data_to_flash_page(page_buf, &sat_data_buf.obdh.data.media.last_page_px_data, nor_info.page_size, CONFIG_MEM_PX_DATA_START_PAGE, CONFIG_MEM_PX_DATA_END_PAGE) != 0)
-            {
-                sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the Payload-X data to the flash memory!");
-                sys_log_new_line();
-            }
+            sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_DATA_LOG_NAME, "Error writing the Payload-X data to the flash memory!");
+            sys_log_new_line();
         }
 
-        null_ptr = memset(&page_buf[0], 0, 256);
+        (void)memset(&page_buf[0], 0, 256);
 
         vTaskDelayUntil(&last_cycle, pdMS_TO_TICKS(TASK_DATA_LOG_PERIOD_MS));
     }
 }
 
-int write_data_to_flash_page(uint8_t *data, uint32_t *page, uint32_t page_size, uint32_t start_page, uint32_t end_page)
-{
-    int err = -1;
-
-    if (media_write(MEDIA_NOR, (*page) * page_size, data, page_size) == 0)
-    {
-        (*page)++;    // cppcheck-suppress misra-c2012-17.8
-
-        if (*page > end_page)
-        {
-            *page = start_page;
-        }
-
-        err = 0;
-    }
-
-    return err;
-}
-
 /** \} End of file_system group */

firmware/app/tasks/housekeeping.c

@@ -24,8 +24,9 @@
  * \brief Housekeeping task implementation.
  * 
  * \author Gabriel Mariano Marcelino <[email protected]>
+ * \author Carlos Augusto Porto Freitas <[email protected]>
  * 
- * \version 0.10.17
+ * \version 0.10.18
  * 
  * \date 2021/04/27
  * 
@@ -68,11 +69,16 @@ void vTaskHousekeeping(void)
         /* Save the last available OBDH data at every minute */
         if ((system_get_time() % 60U) == 0U)
         {
-            if (mem_mng_save_obdh_data_to_fram(sat_data_buf.obdh) != 0)
+            if (mem_mng_save_obdh_data_to_fram(&sat_data_buf.obdh) != 0)
             {
                 sys_log_print_event_from_module(SYS_LOG_ERROR, TASK_HOUSEKEEPING_NAME, "Error writing data to the FRAM memory!");
                 sys_log_new_line();
             }
+            else 
+            {
+                sys_log_print_event_from_module(SYS_LOG_INFO, TASK_HOUSEKEEPING_NAME, "Saving obdh data to fram...");
+                sys_log_new_line();
+            }
         }
 
         vTaskDelayUntil(&last_cycle, pdMS_TO_TICKS(TASK_HOUSEKEEPING_PERIOD_MS));