-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Distributed POST verification #5390
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5390 +/- ##
========================================
Coverage 79.5% 79.5%
========================================
Files 268 268
Lines 26591 26851 +260
========================================
+ Hits 21146 21361 +215
- Misses 3916 3954 +38
- Partials 1529 1536 +7 ☔ View full report in Codecov by Sentry. |
what does it mean? active set is created at the start of the epoch. it is usually created from atxs that are graded as "good", such that were received 2 hours prior epoch start, and no malfeasance proof was received before epoch start. so effectively honest node selects atxs that could have been verified by someone during 2 hours. in cases when it is not created from grades, it will be created as a superset of activesets in the first block. the actual problem here is that we don't have reliable sync for malfeasence proofs, so there is no guarantee that node will receive them within 2 hours from being created. this will either need to be improved before releasing distributed verification, or just be aware of this risk |
bors try |
tryBuild succeeded: |
bors merge |
Part of #5185, closes #5376 - [x] Local randomness seed to select K3 indices using p2p peer ID - [x] Verifying K3 indices of POST - [x] Verifying ALL indices for initial POST - [x] Publishing POST malfeasance proofs - [x] Verifying only the invalid index in POST malfeasance proofs - [x] Verify the candidate for a positioning ATX and its chain - [x] Verify the candidate for a commitment ATX and its chain - [x] Wait "some time" for malfeasance proofs before creating an active set ☝️ this is covered by ATX grading - [x] configurable duration after which ATXs (and their chains) are considered valid (in terms of POST labels) - [x] system tests
Build failed (retrying...): |
bors cancel |
Canceled. |
bors merge |
Part of #5185, closes #5376 - [x] Local randomness seed to select K3 indices using p2p peer ID - [x] Verifying K3 indices of POST - [x] Verifying ALL indices for initial POST - [x] Publishing POST malfeasance proofs - [x] Verifying only the invalid index in POST malfeasance proofs - [x] Verify the candidate for a positioning ATX and its chain - [x] Verify the candidate for a commitment ATX and its chain - [x] Wait "some time" for malfeasance proofs before creating an active set ☝️ this is covered by ATX grading - [x] configurable duration after which ATXs (and their chains) are considered valid (in terms of POST labels) - [x] system tests
Build failed (retrying...):
|
Canceled. |
bors try |
tryBuild failed: |
bors merge |
Part of #5185, closes #5376 - [x] Local randomness seed to select K3 indices using p2p peer ID - [x] Verifying K3 indices of POST - [x] Verifying ALL indices for initial POST - [x] Publishing POST malfeasance proofs - [x] Verifying only the invalid index in POST malfeasance proofs - [x] Verify the candidate for a positioning ATX and its chain - [x] Verify the candidate for a commitment ATX and its chain - [x] Wait "some time" for malfeasance proofs before creating an active set ☝️ this is covered by ATX grading - [x] configurable duration after which ATXs (and their chains) are considered valid (in terms of POST labels) - [x] system tests
Pull request successfully merged into develop. Build succeeded: |
Part of #5185, closes #5376
☝️ this is covered by ATX grading