[Merged by Bors] - Add "until" field to PoetWaitRound, PoetWaitProof, AtxPublished events #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
reviewed
Jan 21, 2024
|
To use the updated API you have to update the dependency: go get github.com/spacemeshos/api/release/go |
|
Updated to use the released api 1.26. I incorporated the review comments from fasmat (thanks!). |
xearl4
changed the title
|
LGTM. Thanks @xearl4 bors merge |
|
👎 Rejected by too few approved reviews |
fasmat
approved these changes
Jan 21, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 21, 2024
#5425) ## Motivation Many people currently use the gRPC AdminService's EventStream for simple go-spacemesh monitoring. This PR adds an "until" field to the PoetWaitRound, PoetWaitProof and AtxPublished events to make it a bit easier to see until when the node will wait after those events ([related recent discussion in Discord](https://discord.com/channels/623195163510046732/691262184050786305/1194552731378122782)). Example events after this change: ```json "poetWaitRound": { "current": 12, "publish": 13, "wait": "29238.819235612s", "until": "2024-01-09T07:00:21.151608967Z" } "poetWaitProof": { "publish": 13, "target": 14, "wait": "987972.244983544s", "until": "2024-01-20T20:00:00.000003843Z" } "atxPublished": { "current": 12, "target": 13, "id": "...", "wait": "292017.668117248s", "until": "2024-01-12T08:00:00.000001993Z" } ``` ## Changes Set the `until` field in the PoetWaitRound, PoetWaitProof, AtxPublished event. This change depends on spacemeshos/api#297. ~~Updates to go.mod/go.sum are pending until a new tagged version of `api`.~~ ## Test Plan Manual testing ## TODO <!-- This section should be removed when all items are complete --> - [X] Explain motivation or link existing issue(s) - [X] Test changes and document test plan - [ ] Update documentation as needed - [ ] Update [changelog](../CHANGELOG.md) as needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5425 +/- ##
=======================================
Coverage 77.6% 77.6%
=======================================
Files 267 267
Lines 30953 30956 +3
=======================================
+ Hits 24038 24045 +7
+ Misses 5398 5395 -3
+ Partials 1517 1516 -1 ☔ View full report in Codecov by Sentry. |
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
#5425) ## Motivation Many people currently use the gRPC AdminService's EventStream for simple go-spacemesh monitoring. This PR adds an "until" field to the PoetWaitRound, PoetWaitProof and AtxPublished events to make it a bit easier to see until when the node will wait after those events ([related recent discussion in Discord](https://discord.com/channels/623195163510046732/691262184050786305/1194552731378122782)). Example events after this change: ```json "poetWaitRound": { "current": 12, "publish": 13, "wait": "29238.819235612s", "until": "2024-01-09T07:00:21.151608967Z" } "poetWaitProof": { "publish": 13, "target": 14, "wait": "987972.244983544s", "until": "2024-01-20T20:00:00.000003843Z" } "atxPublished": { "current": 12, "target": 13, "id": "...", "wait": "292017.668117248s", "until": "2024-01-12T08:00:00.000001993Z" } ``` ## Changes Set the `until` field in the PoetWaitRound, PoetWaitProof, AtxPublished event. This change depends on spacemeshos/api#297. ~~Updates to go.mod/go.sum are pending until a new tagged version of `api`.~~ ## Test Plan Manual testing ## TODO <!-- This section should be removed when all items are complete --> - [X] Explain motivation or link existing issue(s) - [X] Test changes and document test plan - [ ] Update documentation as needed - [ ] Update [changelog](../CHANGELOG.md) as needed
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Many people currently use the gRPC AdminService's EventStream for simple go-spacemesh monitoring. This PR adds an "until" field to the PoetWaitRound, PoetWaitProof and AtxPublished events to make it a bit easier to see until when the node will wait after those events (related recent discussion in Discord).
Example events after this change:
Changes
Set the
untilfield in the PoetWaitRound, PoetWaitProof, AtxPublished event.This change depends on spacemeshos/api#297.
Updates to go.mod/go.sum are pending until a new tagged version ofapi.Test Plan
Manual testing
TODO