Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Improve events emitted by node when post proofing #5470

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Jan 19, 2024

Motivation

Backport of #5139 to v1.3

Changes

Test Plan

n/a

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (06c8efe) 77.3% compared to head (3367de9) 77.3%.
Report is 1 commits behind head on v1.3.

Files Patch % Lines
activation/nipost.go 74.2% 7 Missing and 2 partials ⚠️
api/grpcserver/post_client.go 50.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            v1.3   #5470     +/-   ##
=======================================
- Coverage   77.3%   77.3%   -0.1%     
=======================================
  Files        260     260             
  Lines      30642   30650      +8     
=======================================
- Hits       23701   23697      -4     
- Misses      5446    5455      +9     
- Partials    1495    1498      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat fasmat enabled auto-merge (squash) January 19, 2024 14:01
@fasmat fasmat disabled auto-merge January 19, 2024 14:06
@fasmat fasmat merged commit 6ebcdf4 into v1.3 Jan 19, 2024
16 of 17 checks passed
@fasmat fasmat deleted the backport-handle-grpc-timeouts-better branch January 19, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants