[Merged by Bors] - Refactor NIPostBuilder and activation.Builder for multiple identities. #5484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5484 +/- ##
=======================================
Coverage 79.6% 79.6%
=======================================
Files 268 268
Lines 26707 26746 +39
=======================================
+ Hits 21265 21312 +47
+ Misses 3919 3915 -4
+ Partials 1523 1519 -4 ☔ View full report in Codecov by Sentry. |
fasmat
force-pushed
the
5149-multi-smesher-activation
branch
7 times, most recently
from
38acb54
to
537e610
Compare
fasmat
changed the title
4 tasks
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
## Motivation The ATX handler should not create malfeasance proofs against the node itself. In case we have a bug somewhere that would publish 2 ATXs in a single epoch fail validation, but do not mark yourself as malicious Merge after #5484
fasmat
force-pushed
the
5149-multi-smesher-activation
branch
from
3a76125
to
e8c94ad
Compare
fasmat
added a commit
that referenced
this pull request
Jan 31, 2024
The ATX handler should not create malfeasance proofs against the node itself. In case we have a bug somewhere that would publish 2 ATXs in a single epoch fail validation, but do not mark yourself as malicious Merge after #5484
fasmat
force-pushed
the
5149-multi-smesher-activation
branch
from
4fe5ca3
to
e866570
Compare
fasmat
added a commit
that referenced
this pull request
Jan 31, 2024
The ATX handler should not create malfeasance proofs against the node itself. In case we have a bug somewhere that would publish 2 ATXs in a single epoch fail validation, but do not mark yourself as malicious Merge after #5484
fasmat
force-pushed
the
5149-multi-smesher-activation
branch
3 times, most recently
from
52ee95f
to
0976695
Compare
fasmat
force-pushed
the
5149-multi-smesher-activation
branch
from
eaf33d9
to
cf39e02
Compare
poszu
reviewed
Feb 1, 2024
poszu
approved these changes
Feb 2, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
#5484) ## Motivation <!-- Give a brief description of the motivation for this PR. 1-2 sentences is fine. --> This adds multi-smesher support to the activation package. Specifically to the `activation.Builder` and `activation.NIPostBuilder` services.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This adds multi-smesher support to the activation package. Specifically to the
activation.Builderandactivation.NIPostBuilderservices.Description
Closes #5149
Requires API changes: spacemeshos/api#302
NIPostBuilderto be able to create ATXs for different identitiesactivation.Builderto handle multiple identities concurrentlyTest Plan
TODO