Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #5511: p2p: fix gater blocklist setup #5541

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Feb 5, 2024

Motivation

Backport #5511 to v1.3

## Motivation

The IP blockslists were not initialized properly. This results in "portscans", when the node tries to contact other nodes outside its local network on their private IP. See #5510 for more information
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c307288) 77.3% compared to head (1c7a8a9) 77.3%.
Report is 2 commits behind head on v1.3.

❗ Current head 1c7a8a9 differs from pull request most recent head cef7ed4. Consider uploading reports for the commit cef7ed4 to get more accurate results

Files Patch % Lines
p2p/host.go 50.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            v1.3   #5541     +/-   ##
=======================================
- Coverage   77.3%   77.3%   -0.1%     
=======================================
  Files        261     261             
  Lines      30902   30891     -11     
=======================================
- Hits       23913   23903     -10     
  Misses      5488    5488             
+ Partials    1501    1500      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pigmej pigmej merged commit a997e1d into v1.3 Feb 5, 2024
15 checks passed
@pigmej pigmej deleted the backport-5511 branch February 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants