Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - blocks/certifier: use sql database directly #5546

Closed
wants to merge 1 commit into from

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Feb 6, 2024

related: #5039

it wasn't using any methods that are caching state, so it is a simple cleanup.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9970eec) 79.6% compared to head (226c91e) 79.6%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #5546     +/-   ##
=========================================
- Coverage     79.6%   79.6%   -0.1%     
=========================================
  Files          268     268             
  Lines        26746   26817     +71     
=========================================
+ Hits         21315   21365     +50     
- Misses        3913    3931     +18     
- Partials      1518    1521      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dshulyak
Copy link
Contributor Author

dshulyak commented Feb 6, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Feb 6, 2024
related: #5039

it wasn't using any methods that are caching state, so it is a simple cleanup.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Feb 6, 2024

Build failed:

@dshulyak
Copy link
Contributor Author

dshulyak commented Feb 6, 2024

all tests got interrupted with same message

logger.go:130: 2024-02-06T16:09:54.874Z	WARN	TestFallback	proposals stream error	***"client": "smesher-11", "error": "rpc error: code = Unavailable desc = closing transport due to: connection error: desc = \"error reading from server: EOF\", received prior goaway: code: NO_ERROR, debug data: \"graceful_stop\"", "status": "rpc error: code = Unavailable desc = closing transport due to: connection error: desc = \"error reading from server: EOF\", received prior goaway: code: NO_ERROR, debug data: \"graceful_stop\""***

@dshulyak
Copy link
Contributor Author

dshulyak commented Feb 6, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Feb 6, 2024
related: #5039

it wasn't using any methods that are caching state, so it is a simple cleanup.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Feb 6, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title blocks/certifier: use sql database directly [Merged by Bors] - blocks/certifier: use sql database directly Feb 6, 2024
@spacemesh-bors spacemesh-bors bot closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants