-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - blocks/certifier: use sql database directly #5546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
force-pushed
the
certifier-remove-lru
branch
from
February 6, 2024 08:24
69bb187
to
226c91e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5546 +/- ##
=========================================
- Coverage 79.6% 79.6% -0.1%
=========================================
Files 268 268
Lines 26746 26817 +71
=========================================
+ Hits 21315 21365 +50
- Misses 3913 3931 +18
- Partials 1518 1521 +3 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Feb 6, 2024
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
related: #5039 it wasn't using any methods that are caching state, so it is a simple cleanup.
Build failed: |
all tests got interrupted with same message
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
related: #5039 it wasn't using any methods that are caching state, so it is a simple cleanup.
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
blocks/certifier: use sql database directly
[Merged by Bors] - blocks/certifier: use sql database directly
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #5039
it wasn't using any methods that are caching state, so it is a simple cleanup.