[Merged by Bors] - mesh/executor: extend atxsdata with coinbase to use them when applying blocks #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5547 +/- ##
=======================================
Coverage 79.7% 79.7%
=======================================
Files 267 267
Lines 26831 26828 -3
=======================================
+ Hits 21388 21395 +7
+ Misses 3924 3913 -11
- Partials 1519 1520 +1 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Feb 6, 2024
| @@ -39,7 +39,9 @@ const ( | |||
|
|
|||
| type testMesh struct { | |||
| *Mesh | |||
| db sql.Executor | |||
| db *sql.Database | |||
| cdb *datastore.CachedDB | |||
There was a problem hiding this comment.
it is used in malfeasence.Validate, which is called in the tests, i wanted to avoid refactoring that module in the one change
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
…g blocks (#5547) related: #5192 it adds around 20MB per 1_000_000 atxs. i considered getting them from database (e.g we can do select using atx id primary key index and read coinbase), but it is likely that number of proposals continue to grow in the foreseeable future (each proposal is a separate query) so storing a bit more data is a better option.
|
Build failed:
|
|
needs rebase |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
…g blocks (#5547) related: #5192 it adds around 20MB per 1_000_000 atxs. i considered getting them from database (e.g we can do select using atx id primary key index and read coinbase), but it is likely that number of proposals continue to grow in the foreseeable future (each proposal is a separate query) so storing a bit more data is a better option.
|
Build failed: |
dshulyak
force-pushed
the
executor-coinbases
branch
from
aa0cd29
to
065c400
Compare
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
…g blocks (#5547) related: #5192 it adds around 20MB per 1_000_000 atxs. i considered getting them from database (e.g we can do select using atx id primary key index and read coinbase), but it is likely that number of proposals continue to grow in the foreseeable future (each proposal is a separate query) so storing a bit more data is a better option.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
…g blocks (#5547) related: #5192 it adds around 20MB per 1_000_000 atxs. i considered getting them from database (e.g we can do select using atx id primary key index and read coinbase), but it is likely that number of proposals continue to grow in the foreseeable future (each proposal is a separate query) so storing a bit more data is a better option.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #5192
it adds around 20MB per 1_000_000 atxs.
i considered getting them from database (e.g we can do select using atx id primary key index and read coinbase),
but it is likely that number of proposals continue to grow in the foreseeable future (each proposal is a separate query)
so storing a bit more data is a better option.