[backport] disable mesh agreement #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the goal of mesh agreement is to download ballots and activations when partitions made individual progress. such as in Partition_50_50 or 70_30 tests. however on mainnet it creates unnecessary load by triggering queries to download atx. i suggest to disable that and wait for set reconciliation to fix it. related: spacemeshos#5519
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v1.3 #5548 +/- ##
=======================================
- Coverage 77.3% 77.3% -0.1%
=======================================
Files 261 261
Lines 30891 30892 +1
=======================================
Hits 23903 23903
- Misses 5488 5489 +1
Partials 1500 1500 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
Feb 12, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
the goal of mesh agreement is to download ballots and activations when partitions made individual progress. such as in Partition_50_50 or 70_30 tests. however on mainnet it creates unnecessary load by triggering queries to download atx. i suggest to disable that and wait for set reconciliation to fix it. related: #5519
|
This PR was included in a batch that successfully built, but then failed to merge into v1.3. It will not be retried. Additional information: Response status code: 422
{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the goal of mesh agreement is to download ballots and activations when partitions made individual progress. such as in Partition_50_50 or 70_30 tests.
however on mainnet it creates unnecessary load by triggering queries to download atx. i suggest to disable that and wait for set reconciliation to fix it.
related: #5519