Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 6241: Speed up ATX cache warmup #6246

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Backport 6241: Speed up ATX cache warmup #6246

merged 3 commits into from
Aug 12, 2024

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Aug 12, 2024

Motivation

Backport of #6241

Description

Only backport of #6241

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

## Motivation

Speeding up the in-memory ATX cache warmup that is especially slow on HDDs.



Co-authored-by: Jedrzej Nowak <[email protected]>
@fasmat fasmat self-assigned this Aug 12, 2024
@fasmat fasmat changed the base branch from develop to v1.6 August 12, 2024 17:51
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 75.43860% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.7%. Comparing base (f07c531) to head (2571e53).
Report is 1 commits behind head on v1.6.

Files Patch % Lines
atxsdata/warmup.go 66.6% 5 Missing and 4 partials ⚠️
node/node.go 70.5% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            v1.6   #6246   +/-   ##
=====================================
  Coverage   81.7%   81.7%           
=====================================
  Files        301     301           
  Lines      32306   32321   +15     
=====================================
+ Hits       26416   26429   +13     
- Misses      4170    4171    +1     
- Partials    1720    1721    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat fasmat merged commit 8d594d0 into v1.6 Aug 12, 2024
22 of 23 checks passed
@fasmat fasmat deleted the backport-6241 branch August 12, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants