[Merged by Bors] - build(deps): Bump golang from 1.22 to 1.23 #6256

dependabot · 2024-08-14T01:45:07Z

Bumps golang from 1.22 to 1.23.

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

fasmat

let's wait at least 1-2 patch versions before the upgrade, we should also check if our tooling requires updating before building go-spacemesh with 1.23

fasmat · 2024-09-09T10:12:01Z

quic-go breaks with Go 1.23 unless GODEBUG="asynctimerchan=1" is set. This will probably be fixed with a new minor update of Go 1.23.x, for details see:

timer: fix behavior for new go1.23 timer semantics quic-go/quic-go#4659
runtime,time: timer.Stop returns false even when no value is read from the channel golang/go#69312

Bumps golang from 1.22 to 1.23. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

codecov · 2024-10-02T09:33:51Z

Codecov Report

Attention: Patch coverage is 92.20779% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.6%. Comparing base (c55ec34) to head (8bdb441).
Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
api/grpcserver/admin_service.go	25.0%	3 Missing ⚠️
api/grpcserver/debug_service.go	0.0%	1 Missing ⚠️
timesync/peersync/sync.go	0.0%	1 Missing ⚠️
tortoise/recover.go	50.0%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #6256   +/-   ##
=======================================
  Coverage     81.6%   81.6%           
=======================================
  Files          314     313    -1     
  Lines        35021   34960   -61     
=======================================
- Hits         28605   28559   -46     
+ Misses        4576    4562   -14     
+ Partials      1840    1839    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fasmat

bors try

fasmat · 2024-10-02T10:59:21Z

I updated the codebase to use 1.23, updated golanci-lint and fixed new issues it reported. Since 1.23.2 fixes the timer issue we can now update 🙂

spacemesh-bors · 2024-10-02T11:03:32Z

try

Build failed:

ci-status

txs/mempool_iterator.go

fasmat · 2024-10-02T12:02:29Z

bors merge

Bumps golang from 1.22 to 1.23. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang&package-manager=docker&previous-version=1.22&new-version=1.23)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: Matthias <[email protected]>

spacemesh-bors · 2024-10-02T12:29:16Z

Build failed:

ci-status

fasmat · 2024-10-02T12:40:29Z

bors merge

Bumps golang from 1.22 to 1.23. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang&package-manager=docker&previous-version=1.22&new-version=1.23)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: Matthias <[email protected]>

spacemesh-bors · 2024-10-02T14:11:38Z

Pull request successfully merged into develop.

Build succeeded:

dependabot · 2024-10-02T14:11:41Z

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot bot requested review from dshulyak, fasmat, poszu and ivan4th as code owners August 14, 2024 01:45

dependabot bot added the dependencies Pull requests that update a dependency file label Aug 14, 2024

dependabot bot requested a review from acud as a code owner August 14, 2024 01:45

dependabot bot added the docker Pull requests that update Docker code label Aug 14, 2024

fasmat requested changes Aug 14, 2024

View reviewed changes

fasmat mentioned this pull request Aug 26, 2024

Bump golang from 1.22-alpine to 1.23-alpine spacemeshos/poet#507

Closed

dependabot bot and others added 2 commits October 2, 2024 11:06

build(deps): Bump golang from 1.22 to 1.23

ba0f8d0

Bumps golang from 1.22 to 1.23. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Update Go to 1.23

f1b97cf

fasmat force-pushed the dependabot/docker/golang-1.23 branch from 0a5e306 to c383dfe Compare October 2, 2024 09:12

Update golangci lint configuration and fix warnings

103716b

fasmat force-pushed the dependabot/docker/golang-1.23 branch from c383dfe to 103716b Compare October 2, 2024 09:44

fasmat added 2 commits October 2, 2024 09:45

Fix typo

6f990f1

Cleanup

4dd9173

fasmat force-pushed the dependabot/docker/golang-1.23 branch from 0464aed to 4dd9173 Compare October 2, 2024 10:21

Update dependencies

bba1fbb

fasmat approved these changes Oct 2, 2024

View reviewed changes

spacemesh-bors bot added a commit that referenced this pull request Oct 2, 2024

Try #6256:

4b06d25

Fix linter complaints

3ab75d0

Fix warnings

fa4b1be

jellonek reviewed Oct 2, 2024

View reviewed changes

txs/mempool_iterator.go Outdated Show resolved Hide resolved

Review feedback

8bdb441

spacemesh-bors bot changed the title ~~build(deps): Bump golang from 1.22 to 1.23~~ [Merged by Bors] - build(deps): Bump golang from 1.22 to 1.23 Oct 2, 2024

spacemesh-bors bot closed this Oct 2, 2024

spacemesh-bors bot deleted the dependabot/docker/golang-1.23 branch October 2, 2024 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - build(deps): Bump golang from 1.22 to 1.23 #6256

[Merged by Bors] - build(deps): Bump golang from 1.22 to 1.23 #6256

dependabot bot commented on behalf of github Aug 14, 2024 •

edited

Loading

fasmat left a comment

fasmat commented Sep 9, 2024

codecov bot commented Oct 2, 2024 •

edited

Loading

fasmat left a comment

fasmat commented Oct 2, 2024

spacemesh-bors bot commented Oct 2, 2024

fasmat commented Oct 2, 2024

spacemesh-bors bot commented Oct 2, 2024

fasmat commented Oct 2, 2024

spacemesh-bors bot commented Oct 2, 2024

dependabot bot commented on behalf of github Oct 2, 2024

[Merged by Bors] - build(deps): Bump golang from 1.22 to 1.23 #6256

[Merged by Bors] - build(deps): Bump golang from 1.22 to 1.23 #6256

Conversation

dependabot bot commented on behalf of github Aug 14, 2024 • edited Loading

fasmat left a comment

Choose a reason for hiding this comment

fasmat commented Sep 9, 2024

codecov bot commented Oct 2, 2024 • edited Loading

Codecov Report

fasmat left a comment

Choose a reason for hiding this comment

fasmat commented Oct 2, 2024

spacemesh-bors bot commented Oct 2, 2024

try

fasmat commented Oct 2, 2024

spacemesh-bors bot commented Oct 2, 2024

fasmat commented Oct 2, 2024

spacemesh-bors bot commented Oct 2, 2024

dependabot bot commented on behalf of github Oct 2, 2024

dependabot bot commented on behalf of github Aug 14, 2024 •

edited

Loading

codecov bot commented Oct 2, 2024 •

edited

Loading