Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 6268: Update time measurement of metrics for proposal builder in 1:n #6282

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Aug 22, 2024

Motivation

Backport of #6268

Description

This only backport #6268 and updates the CHANGELOG

Test Plan

existing tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.7%. Comparing base (f07c531) to head (9a5d30c).
Report is 10 commits behind head on v1.6.

Additional details and impacted files
@@           Coverage Diff           @@
##            v1.6   #6282     +/-   ##
=======================================
- Coverage   81.7%   81.7%   -0.1%     
=======================================
  Files        301     301             
  Lines      32306   32291     -15     
=======================================
- Hits       26416   26401     -15     
+ Misses      4170    4169      -1     
- Partials    1720    1721      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

## Motivation

This updates how timing metrics for the proposal builder are calculated.
@fasmat fasmat enabled auto-merge (squash) August 22, 2024 15:19
@fasmat fasmat merged commit 172f4cf into v1.6 Aug 22, 2024
23 checks passed
@fasmat fasmat deleted the backport-6268 branch August 22, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants