Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/steiger service docs round2 #252

Merged
merged 13 commits into from
Oct 21, 2024
Merged

Feature/steiger service docs round2 #252

merged 13 commits into from
Oct 21, 2024

Conversation

steigersg
Copy link
Contributor

@steigersg steigersg commented Oct 17, 2024 •
edited
Loading

Another round of service docs for catkit2 (see issue #190 for more information).

Services included:

  • Thorlabs temperarure Sensor
  • Thorlabs filter wheel
  • Thorlabs flip mount
  • Simulated Camera

@steigersg steigersg self-assigned this Oct 17, 2024
@steigersg steigersg mentioned this pull request Oct 17, 2024
Open
21 tasks
@steigersg steigersg marked this pull request as ready for review October 17, 2024 15:41
ivalaginja
ivalaginja reviewed Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@ivalaginja ivalaginja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Just some minor comments to hopefully clarify things further.

docs/services/camera_sim.rst Outdated Show resolved Hide resolved
docs/services/camera_sim.rst Outdated Show resolved Hide resolved
docs/services/camera_sim.rst Show resolved Hide resolved
docs/services/thorlabs_fw102c.rst Outdated Show resolved Hide resolved
docs/services/thorlabs_fw102c.rst Outdated Show resolved Hide resolved
docs/services/thorlabs_mff101.rst Outdated Show resolved Hide resolved
docs/services/thorlabs_mff101.rst Outdated Show resolved Hide resolved
ivalaginja
ivalaginja approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@ivalaginja ivalaginja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Thanks so much again!

@steigersg steigersg merged commit 87c27be into develop Oct 21, 2024
6 checks passed
@steigersg steigersg deleted the feature/steiger_service_docs_round2 branch October 21, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivalaginja ivalaginja ivalaginja approved these changes

@raphaelpclt raphaelpclt Awaiting requested review from raphaelpclt

Assignees

@steigersg steigersg

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steigersg @ivalaginja