Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in id property access of Hamamatsu camera #261

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix typo in id property access of Hamamatsu camera #261

merged 1 commit into from
Oct 28, 2024

Conversation

johanmazoyer
Copy link
Collaborator

Fixed a typo in hamamatsu service.
Found while running benchmark_camera experiment on hardware

@johanmazoyer johanmazoyer self-assigned this Oct 28, 2024
ivalaginja
ivalaginja approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@ivalaginja ivalaginja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen it work with this change, good to go.

@ivalaginja ivalaginja merged commit 3e304d6 into develop Oct 28, 2024
6 checks passed
@ivalaginja ivalaginja deleted the fix_typo_hamamatsu branch October 28, 2024 18:03
@ivalaginja ivalaginja changed the title fix typo in id property access FIx typo in id property access of Hamamatsu camera Oct 28, 2024
@ivalaginja ivalaginja changed the title FIx typo in id property access of Hamamatsu camera Fix typo in id property access of Hamamatsu camera Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivalaginja ivalaginja ivalaginja approved these changes

Assignees

@johanmazoyer johanmazoyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanmazoyer @ivalaginja