Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace usages of copy_arrays with memmap #503

Merged

Conversation

zacharyburnett
Copy link
Collaborator

follow-on to asdf-format/asdf#1797

@zacharyburnett zacharyburnett self-assigned this Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.26%. Comparing base (eb9d316) to head (4e289c3).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
- Coverage   87.28%   87.26%   -0.03%     
==========================================
  Files          22       21       -1     
  Lines        3821     3815       -6     
==========================================
- Hits         3335     3329       -6     
  Misses        486      486              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

replace usages of ``copy_arrays`` with ``memmap``
@zacharyburnett zacharyburnett marked this pull request as ready for review July 18, 2024 19:52
@zacharyburnett zacharyburnett requested a review from a team as a code owner July 18, 2024 19:52
@braingram
Copy link
Collaborator

It looks like the version check doesn't like dev versions:
https://github.com/spacetelescope/gwcs/actions/runs/9997771007/job/27635131897?pr=503#step:10:300
Would you change this to https://docs.astropy.org/en/stable/api/astropy.utils.introspection.minversion.html#minversion

@nden
Copy link
Collaborator

nden commented Jul 21, 2024

I cannot reproduce the failure locally with numpy 2.0, scipy 1.14.0 and astropy 6.1.1. The only difference as far as I can tell is locally I'm running it on MacOS Monterey. Can you set atol=1e-15 in the failing test?

@braingram
Copy link
Collaborator

braingram commented Jul 22, 2024

I was able to replicate this and narrow it down to scipy 1.14.0.
Here's an issue:
#504
and a PR that adjusts the tolerances for the test:
#505

@nden nden added this to the 0.22 milestone Jul 30, 2024
@zacharyburnett zacharyburnett merged commit 735c306 into spacetelescope:master Jul 30, 2024
22 of 23 checks passed
@zacharyburnett zacharyburnett deleted the deprecate/copy_arrays branch July 30, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants