Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcviz support: fix data-menu item visibility cloned phase-viewer #2640

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jan 2, 2024

Description

This pull request updates the logic for data-item visibility within the data-menu for lcviz (currently upstream until we refactor and have a way to override this downstream) to handle the new flexibility introduced by spacetelescope/lcviz#74

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Jan 2, 2024
@kecnry kecnry added this to the 3.9 milestone Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b997fb) 91.52% compared to head (e25e571) 91.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2640   +/-   ##
=======================================
  Coverage   91.52%   91.53%           
=======================================
  Files         161      161           
  Lines       19989    19989           
=======================================
+ Hits        18295    18296    +1     
+ Misses       1694     1693    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks like code. Unless you want another lcviz dev to look at this.

@kecnry kecnry merged commit 3a13801 into spacetelescope:main Jan 2, 2024
18 of 19 checks passed
@kecnry kecnry deleted the lcviz-cloned-phase-viewer branch January 2, 2024 20:17
@kecnry kecnry mentioned this pull request Jan 2, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants