Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stretch_global switch in plot options #2814

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Apr 17, 2024

Description

This pull request implements support for toggling whether stretch is handled per-slice or globally across the cube (for cubeviz only).

Screen.Recording.2024-04-17.at.1.06.18.PM.mov

This replaces #2621 and #2694 and would require glue-viz/glue#2476 to be merged/pinned.

TODO:

  • update histogram data based on selection.
  • if set to per-slice, update histogram on change to selected slice (and update screen recording)
  • fix tests (histogram colorbar needs updating)

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.10 milestone Apr 17, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Apr 17, 2024
to match upstream PR changes
@bmorris3 bmorris3 modified the milestones: 3.10, 3.11 May 3, 2024
@rosteen rosteen modified the milestones: 3.11, 4.1 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants