Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit conversion with spectral density and surface brightness equivalency at the same time #2890

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

astrofrog
Copy link
Collaborator

Description

The goal here is to try and make sure that we can convert between e.g. MJy and ergs/cm^2/s/AA/sr. However this doesn't work currently, probably because the equivalencies aren't being combined in the right way. I'll see if I can distil this down to a simple example to put to the astropy.units maintainers (if people here don't know how to fix this).

This would need to be rebased once #2888 and #2889 are merged as it includes the changes there.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added this to the 4.0 milestone May 22, 2024
@pllim pllim added Close? Close if no longer relevant bug Something isn't working and removed Close? Close if no longer relevant labels May 22, 2024
@gibsongreen gibsongreen added the no-changelog-entry-needed changelog bot directive label May 31, 2024
@rosteen rosteen modified the milestones: 4.0, 4.1 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-changelog-entry-needed changelog bot directive testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants