-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix logos and dark mode #3245
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3245 +/- ##
=======================================
Coverage 88.63% 88.63%
=======================================
Files 125 125
Lines 18779 18779
=======================================
Hits 16644 16644
Misses 2135 2135 ☔ View full report in Codecov by Sentry. |
Hi @pllim, |
Hmm. I removed the "Note" part. Not sure why you see that locally. |
Yes. I realized that later. Thanks! |
iirc, the backgrounds are white, not transparent, so inverting was the best temporary solution. If we replace the logos with transparent backgrounds, then we can avoid inverting. |
They were inverted on purpose (easier on the eyes and look better in dark mode). But we can un-invert if you want, though that is beyond fixing the layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This comment was marked as resolved.
This comment was marked as resolved.
@haticekaratay , thanks for the review! I will let you handle your JIRA ticket for this as you see fit. |
Doc at 3.10.x actually not affected, so updated milestone. FYI. |
…5-on-v4.0.x Backport PR #3245 on branch v4.0.x (DOC: Fix logos and dark mode)
Description
This pull request is an alternate fix for the logos based on astropy/astropy#16639
Close #3243
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.