DOC: Fix logos and dark mode

[pllim]

Description

This pull request is an alternate fix for the logos based on astropy/astropy#16639

Close #3243

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (f552510) to head (a19c09a).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3245   +/-   ##
=======================================
  Coverage   88.63%   88.63%           
=======================================
  Files         125      125           
  Lines       18779    18779           
=======================================
  Hits        16644    16644           
  Misses       2135     2135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[haticekaratay]

Hi @pllim,
Could you please add before and after screenshots demonstrating how the docs are built at the end? I'm asking because I'm currently testing it locally and wondering if this is what we expect to see in dark mode:

[pllim]

Hmm. I removed the "Note" part. Not sure why you see that locally.

Before: https://jdaviz.readthedocs.io/en/latest/

After: https://jdaviz--3245.org.readthedocs.build/en/3245/

[haticekaratay]

Hmm. I removed the "Note" part. Not sure why you see that locally.

Before: https://jdaviz.readthedocs.io/en/latest/

After: https://jdaviz--3245.org.readthedocs.build/en/3245/

Yes. I realized that later. Thanks!

[haticekaratay]

@pllim
One more question: Should we invert the colors of the logo in dark mode, or keep them as they are? @kecnry

[kecnry]

iirc, the backgrounds are white, not transparent, so inverting was the best temporary solution. If we replace the logos with transparent backgrounds, then we can avoid inverting.

[pllim]

Should we invert the colors of the logo in dark mode

They were inverted on purpose (easier on the eyes and look better in dark mode). But we can un-invert if you want, though that is beyond fixing the layout.

[haticekaratay]

Thanks!

[pllim]

@haticekaratay , thanks for the review! I will let you handle your JIRA ticket for this as you see fit.

[pllim]

Doc at 3.10.x actually not affected, so updated milestone. FYI.