-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert combination mode to before import_region call #3255
Revert combination mode to before import_region call #3255
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
=======================================
Coverage 88.63% 88.63%
=======================================
Files 125 125
Lines 18779 18781 +2
=======================================
+ Hits 16644 16646 +2
Misses 2135 2135 ☔ View full report in Codecov by Sentry. |
Is this testable as a unit test? |
# Revert edit mode to before the import_region call | ||
self.app.session.edit_subset_mode.mode = previous_mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there anything above that could actually raise an error (not caught by bad_regions
) where the revert should still happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I could see, does anything stick out to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we don't need to catch bugs in the code itself, so bad_regions
should be sufficient to make sure the revert happens here. Thanks!
@@ -198,6 +199,7 @@ def test_import_spectral_region(cubeviz_helper, spectrum1d_cube, spec_regions, m | |||
subsets = cubeviz_helper.app.get_subsets() | |||
assert len(subsets) == len_subsets | |||
assert len(subsets['Subset 1']) == len_subregions | |||
assert cubeviz_helper.app.session.edit_subset_mode.mode == ReplaceMode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pllim I added this and the lines below, let me know if that is sufficient coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Revert combination mode to before import_region call * Add unit test for reverting to previous edit mode * Remove whitespace
Description
This pull request reverts the combination mode to before the
import_region(region, combination_mode=<list>)
call.Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.