Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UI elements deprecated since 3.9 #3256

Merged
merged 10 commits into from
Oct 28, 2024

Conversation

haticekaratay
Copy link
Contributor

@haticekaratay haticekaratay commented Oct 24, 2024

Description

This pull request removes deprecated logic related to the "SAVE as FITS" option from the Collapse, Moment Maps, and Spectral Extraction plugins. These options were already deprecated and have now been fully removed from the UI. Instead, the process of exporting files is centralized in a separate Export Plugin, reducing redundancy.

To illustrate the updates, check the before-and-after videos that highlight the UI changes.

BEFORE:

Screen.Recording.2024-10-28.at.11.01.06.AM.mov

AFTER:

Screen.Recording.2024-10-28.at.11.04.51.AM.mov

Fixes #

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added cubeviz embed Regarding issues with front-end embedding plugin Label for plugins common to multiple configurations labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (f552510) to head (d15bb57).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3256      +/-   ##
==========================================
+ Coverage   88.63%   88.64%   +0.01%     
==========================================
  Files         125      125              
  Lines       18779    18708      -71     
==========================================
- Hits        16644    16584      -60     
+ Misses       2135     2124      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haticekaratay haticekaratay added this to the 4.0.1 milestone Oct 25, 2024
@haticekaratay haticekaratay changed the title WIP: Remove UI elements deprecated since 3.9 Remove UI elements deprecated since 3.9 Oct 28, 2024
@haticekaratay haticekaratay marked this pull request as ready for review October 28, 2024 15:21
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like +18 −409. Just a minor comment on change log entry. Thanks!

CHANGES.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim modified the milestones: 4.0.1, 4.1 Oct 28, 2024
@pllim
Copy link
Contributor

pllim commented Oct 28, 2024

I think we agreed to put this in 4.1 and not 4.0.1 right, @kecnry ?

@haticekaratay haticekaratay merged commit 491bdbf into spacetelescope:main Oct 28, 2024
17 checks passed
rosteen pushed a commit that referenced this pull request Oct 29, 2024
* Remove UI elements deprecated since 3.9

* Add change log

* Remove deprecated save as fits in spectral extraction plugin

* Remove unused tooltips

* Remove unused vue write methods

* Update tests after removing the deprecated methods

* Update change log

* Update tests and fix code style

* Update changelog

* Update the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz embed Regarding issues with front-end embedding plugin Label for plugins common to multiple configurations Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants