-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove UI elements deprecated since 3.9 #3256
Remove UI elements deprecated since 3.9 #3256
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3256 +/- ##
==========================================
+ Coverage 88.63% 88.64% +0.01%
==========================================
Files 125 125
Lines 18779 18708 -71
==========================================
- Hits 16644 16584 -60
+ Misses 2135 2124 -11 ☔ View full report in Codecov by Sentry. |
39ddfb2
to
67d35a6
Compare
jdaviz/configs/cubeviz/plugins/spectral_extraction/spectral_extraction.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like +18 −409
. Just a minor comment on change log entry. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think we agreed to put this in 4.1 and not 4.0.1 right, @kecnry ? |
* Remove UI elements deprecated since 3.9 * Add change log * Remove deprecated save as fits in spectral extraction plugin * Remove unused tooltips * Remove unused vue write methods * Update tests after removing the deprecated methods * Update change log * Update tests and fix code style * Update changelog * Update the changelog
Description
This pull request removes deprecated logic related to the "SAVE as FITS" option from the Collapse, Moment Maps, and Spectral Extraction plugins. These options were already deprecated and have now been fully removed from the UI. Instead, the process of exporting files is centralized in a separate Export Plugin, reducing redundancy.
To illustrate the updates, check the before-and-after videos that highlight the UI changes.
BEFORE:
Screen.Recording.2024-10-28.at.11.01.06.AM.mov
AFTER:
Screen.Recording.2024-10-28.at.11.04.51.AM.mov
Fixes #
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.