-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Rampviz logo from Jenn #3257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorris3
added
documentation
Explanation of code and concepts
trivial
Only needs one approval instead of two
no-changelog-entry-needed
changelog bot directive
labels
Oct 25, 2024
bmorris3
requested review from
rosteen,
javerbukh,
pllim,
kecnry,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
October 25, 2024 14:08
kecnry
approved these changes
Oct 25, 2024
that's happening on all PRs and unrelated |
Then auto merge won't work. You need to manually merge with admin override. |
Co-authored-by: Jennifer Kotler <[email protected]>
bmorris3
force-pushed
the
rampviz-logo
branch
from
October 25, 2024 19:17
1a717db
to
33aaa14
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Oct 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3257 +/- ##
=======================================
Coverage 88.63% 88.63%
=======================================
Files 125 125
Lines 18779 18779
=======================================
Hits 16644 16644
Misses 2135 2135 ☔ View full report in Codecov by Sentry. |
pllim
added a commit
that referenced
this pull request
Oct 25, 2024
…7-on-v4.0.x Backport PR #3257 on branch v4.0.x (Adding Rampviz logo from Jenn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v4.0.x
on-merge: backport to v4.0.x
documentation
Explanation of code and concepts
no-changelog-entry-needed
changelog bot directive
trivial
Only needs one approval instead of two
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Jenneh has created this awesome Rampviz logo for us.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.