Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Rampviz logo from Jenn #3257

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

bmorris3
Copy link
Contributor

Description

@Jenneh has created this awesome Rampviz logo for us.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@bmorris3 bmorris3 added documentation Explanation of code and concepts trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Oct 25, 2024
@bmorris3 bmorris3 added this to the 4.0.1 milestone Oct 25, 2024
@bmorris3 bmorris3 added the backport-v4.0.x on-merge: backport to v4.0.x label Oct 25, 2024
@pllim
Copy link
Contributor

pllim commented Oct 25, 2024

@kecnry
Copy link
Member

kecnry commented Oct 25, 2024

that's happening on all PRs and unrelated

@pllim
Copy link
Contributor

pllim commented Oct 25, 2024

Then auto merge won't work. You need to manually merge with admin override.

Co-authored-by: Jennifer Kotler <[email protected]>
@bmorris3 bmorris3 merged commit 915cee7 into spacetelescope:main Oct 25, 2024
16 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (236f75a) to head (33aaa14).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3257   +/-   ##
=======================================
  Coverage   88.63%   88.63%           
=======================================
  Files         125      125           
  Lines       18779    18779           
=======================================
  Hits        16644    16644           
  Misses       2135     2135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pllim added a commit that referenced this pull request Oct 25, 2024
…7-on-v4.0.x

Backport PR #3257 on branch v4.0.x (Adding Rampviz logo from Jenn)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.0.x on-merge: backport to v4.0.x documentation Explanation of code and concepts no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants