metadata: monkeypatch Undefined to show as empty string #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
force-pushed
the
metadata-undefined
branch
from
449c576
to
3de24e0
Compare
bmorris3
approved these changes
Apr 19, 2024
|
I did first look into a jdaviz fix, but it would require probably introducing inefficiencies to this map line by adding if-statements to override this particular case. That may be worth it at some point though if there are other situations that need special treatment as well 🤔 |
kecnry
added a commit
that referenced
this pull request
Apr 19, 2024
* monkeypatch Undefined to show as empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #88 by monkeypatching the string representation of
astropy.io.fits.card.Undefinedto show an empty string in the metadata plugin instead of something like<astropy.io.fits.card.Undefined object at 0x29f5b94d0>