Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CDIPS parsing support (column filled with strings) #122

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jun 26, 2024

which affected CDIPS HLSP light curves and prevented them from being loaded into lcviz. Note that the time format is still incorrect, but that is a separate issue.

affects CDIPS HLSP light curves
@kecnry kecnry added this to the 0.4.1 milestone Jun 26, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.15%. Comparing base (7b78df5) to head (b547ad6).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
lcviz/utils.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   93.92%   91.15%   -2.78%     
==========================================
  Files          37       41       +4     
  Lines        1598     2058     +460     
==========================================
+ Hits         1501     1876     +375     
- Misses         97      182      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry changed the title fix units with empty strings fix CDIPS support (column filled with strings) Jun 27, 2024
@kecnry kecnry changed the title fix CDIPS support (column filled with strings) fix CDIPS parsing support (column filled with strings) Jun 27, 2024
@kecnry kecnry requested a review from bmorris3 June 27, 2024 13:28
@kecnry kecnry marked this pull request as ready for review June 27, 2024 13:28
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough fix, and I checked that it works for me by running:

from lcviz import LCviz
from astroquery.mast import Observations

ticid = '210400528'
obs_table = Observations.query_criteria(target_name=ticid, provenance_name="CDIPS")
print("Found " + str(len(obs_table)) + " CDIPS light curves.")

# Get list of available products for this Observation.
cdips_products = Observations.get_product_list(obs_table)

manifest = Observations.download_products(cdips_products)

lcviz = LCviz()

for path in manifest['Local Path']:
    lcviz.load_data(path)

lcviz.show()

It raises lots of warnings about the units of many columns, but I'm pretty sure that's on the astropy Tables+this data product, and not on LCviz.

@bmorris3 bmorris3 merged commit b0226b7 into spacetelescope:main Jun 28, 2024
11 of 13 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/lcviz that referenced this pull request Jun 28, 2024
kecnry added a commit that referenced this pull request Jul 1, 2024
@kecnry kecnry deleted the fix-hlsp-unitless branch July 2, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants