-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix CDIPS parsing support (column filled with strings) #122
Conversation
affects CDIPS HLSP light curves
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 93.92% 91.15% -2.78%
==========================================
Files 37 41 +4
Lines 1598 2058 +460
==========================================
+ Hits 1501 1876 +375
- Misses 97 182 +85 ☔ View full report in Codecov by Sentry. |
0980508
to
9a405ce
Compare
9a405ce
to
b547ad6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple enough fix, and I checked that it works for me by running:
from lcviz import LCviz
from astroquery.mast import Observations
ticid = '210400528'
obs_table = Observations.query_criteria(target_name=ticid, provenance_name="CDIPS")
print("Found " + str(len(obs_table)) + " CDIPS light curves.")
# Get list of available products for this Observation.
cdips_products = Observations.get_product_list(obs_table)
manifest = Observations.download_products(cdips_products)
lcviz = LCviz()
for path in manifest['Local Path']:
lcviz.load_data(path)
lcviz.show()
It raises lots of warnings about the units of many columns, but I'm pretty sure that's on the astropy Tables+this data product, and not on LCviz.
…led with strings)
…gs) (#123) Co-authored-by: Kyle Conroy <[email protected]>
which affected CDIPS HLSP light curves and prevented them from being loaded into lcviz. Note that the time format is still incorrect, but that is a separate issue.