Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(temporarily) max pin numpy<2 #126

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jul 15, 2024

Was included in #120, but never backported.

@kecnry kecnry added this to the 0.4.1 milestone Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v0.4.x@2e8602f). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             v0.4.x     #126   +/-   ##
=========================================
  Coverage          ?   91.01%           
=========================================
  Files             ?       41           
  Lines             ?     2059           
  Branches          ?        0           
=========================================
  Hits              ?     1874           
  Misses            ?      185           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review July 15, 2024 12:24
@kecnry kecnry merged commit 6def35d into spacetelescope:v0.4.x Jul 15, 2024
13 of 14 checks passed
@kecnry kecnry deleted the numpy-max-pin branch July 15, 2024 12:24
@dhomeier
Copy link

dhomeier commented Jul 18, 2024

@kecnry I have opened lightkurve/lightkurve#1452 to remove the strict dependency on oktopus; in a fresh environment this allows installation with numpy 2.0 for Python 3.10+, although in the CI still some other packages are blocking numpy > 1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial no review required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants