Fix for ephemeris phase axis #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorris3
commented
Aug 16, 2023
bmorris3
commented
Aug 16, 2023
| @@ -116,7 +116,7 @@ | |||
| "eph = lcviz.plugins['Ephemeris']\n", | |||
| "eph.period = morris2017_period\n", | |||
| "eph.t0 = (\n", | |||
| " (morris2017_epoch - reference_time).to_value(time_coord.unit) % eph.period\n", | |||
| " (morris2017_epoch - reference_time).to_value(time_coordinates.unit) % eph.period\n", | |||
There was a problem hiding this comment.
Sorry I didn't catch this bug earlier.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 84.53% 85.65% +1.11%
==========================================
Files 24 24
Lines 1080 1122 +42
==========================================
+ Hits 913 961 +48
+ Misses 167 161 -6
☔ View full report in Codecov by Sentry. |
bmorris3
force-pushed
the
fix-ephem-x_att
branch
from
06ff36d
to
417fea9
Compare
|
Looking back at this section of code (in |
kecnry
reviewed
Aug 17, 2023
kecnry
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for phase axis
ComponentIDs that restores ephemeris support. 🐱.