Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ephemeris phase axis #37

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Conversation

bmorris3
Copy link
Contributor

Fix for phase axis ComponentIDs that restores ephemeris support. 🐱.

lcviz/marks.py Outdated Show resolved Hide resolved
@@ -116,7 +116,7 @@
"eph = lcviz.plugins['Ephemeris']\n",
"eph.period = morris2017_period\n",
"eph.t0 = (\n",
" (morris2017_epoch - reference_time).to_value(time_coord.unit) % eph.period\n",
" (morris2017_epoch - reference_time).to_value(time_coordinates.unit) % eph.period\n",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't catch this bug earlier.

@bmorris3 bmorris3 requested a review from kecnry August 16, 2023 14:21
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 96.34% and project coverage change: +1.11% 🎉

Comparison is base (ed041c5) 84.53% compared to head (e5a4ba7) 85.65%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   84.53%   85.65%   +1.11%     
==========================================
  Files          24       24              
  Lines        1080     1122      +42     
==========================================
+ Hits          913      961      +48     
+ Misses        167      161       -6     
Files Changed Coverage Δ
lcviz/plugins/coords_info/coords_info.py 94.73% <50.00%> (-0.97%) ⬇️
lcviz/state.py 59.52% <94.44%> (+26.19%) ⬆️
lcviz/utils.py 87.37% <95.45%> (+1.52%) ⬆️
lcviz/helper.py 94.73% <100.00%> (-0.18%) ⬇️
lcviz/parsers.py 79.06% <100.00%> (+10.64%) ⬆️
lcviz/plugins/ephemeris/ephemeris.py 89.07% <100.00%> (+2.06%) ⬆️
lcviz/plugins/flatten/flatten.py 74.35% <100.00%> (+0.44%) ⬆️
lcviz/viewers.py 92.62% <100.00%> (+0.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry
Copy link
Member

kecnry commented Aug 17, 2023

Looking back at this section of code (in ephemeris.py), I'm a bit confused by add_link vs set_links. Can we safely remove the individual add_link call and perhaps swap out set_links(links) with add_link(links)? I'm worried otherwise we might be clearing links we intentionally set in other places - either now or down the road.

@bmorris3
Copy link
Contributor Author

@kecnry In b8e0bd3 I use only add_link.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have done the trick - thanks!

@kecnry kecnry merged commit 874cd51 into spacetelescope:main Aug 17, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants