Flatten: separate previews for flattened and trend #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
added
the
waiting-on-jdaviz-release
kecnry
force-pushed
the
flatten-separate-preview
branch
from
aa8749d
to
9fd0a51
Compare
kecnry
force-pushed
the
flatten-separate-preview
branch
2 times, most recently
from
e75a649
to
d3c51f3
Compare
kecnry
removed
the
waiting-on-jdaviz-release
kecnry
force-pushed
the
flatten-separate-preview
branch
3 times, most recently
from
ae1e5aa
to
c49f5e9
Compare
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
kecnry
force-pushed
the
flatten-separate-preview
branch
from
c49f5e9
to
4f53454
Compare
bmorris3
approved these changes
Oct 19, 2023
| @@ -43,6 +46,7 @@ class Flatten(PluginTemplateMixin, DatasetSelectMixin, AddResultsMixin): | |||
| uses_active_status = Bool(True).tag(sync=True) | |||
|
|
|||
| show_live_preview = Bool(True).tag(sync=True) | |||
| show_trend_preview = Bool(True).tag(sync=True) | |||
There was a problem hiding this comment.
Suggested change
| show_trend_preview = Bool(True).tag(sync=True) | |
| show_trend_preview = Bool(False).tag(sync=True) |
Take or leave this suggestion, but I think the default should be less cluttered and redundant. Especially since the trend color and live preview color are identical, there's a lot to see in the viewer if this is enabled by default.
There was a problem hiding this comment.
usually I actually prefer to see the trend over the preview 🤷♂️ Let's leave for now and revisit as we use it more.
Co-authored-by: Brett M. Morris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR should be rebased after #38 is merged (currently builds on top of it to avoid needing to re-implement), and therefore needs to wait for jdaviz 3.7 to be released.This PR separates the plugin-settings switch for live-previews in the flattening plugin to control the (unnormalized) flattened light curve and the trend separately. In cases where there is not much flattening to be done, it is difficult to see the trend and ensure it is correct if the flattened light curve is directly on top.
Screen.Recording.2023-10-19.at.9.47.14.AM.mov