Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V-FRAME aperture #294

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Conversation

tonysohn
Copy link
Collaborator

@tonysohn tonysohn commented Feb 21, 2023

  • In pysiaf/siaf.py, all instances of "J-FRAME" are duplicated or replaced with “V-FRAME”

  • generate/generate_fgs.py code has been significantly modified to add V-FRAME aperture, and to future proof for adding additional apertures later if necessary.

  • In pysiaf/source_data/FGS , 3 files were modified as follows:
    fgs_siaf_alignment.txt -> Added an aperture named V-FRAME with all other parameters set to “0”, except the SciAngles to “None” (following what’s done for J-FRAME).
    fgs_siaf_aperture_definition.txt -> Added V-FRAME with exactly the same parameters as J-FRAME
    fgs_siaf_ddc_apername_mappint.txt -> Added V-FRAME with exactly the same parameters as J-FRAME

Copy link
Collaborator

@Witchblade101 Witchblade101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All updated checks passed. Verified V-FRAME has been added. Includes some pre-delivery files, but those can be deleted later, as usual.

@Witchblade101 Witchblade101 merged commit ea4e89a into spacetelescope:master Sep 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants