Add V-FRAME aperture #294
Merged
Add V-FRAME aperture #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Witchblade101
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pysiaf/siaf.py, all instances of "J-FRAME" are duplicated or replaced with “V-FRAME”
generate/generate_fgs.py code has been significantly modified to add V-FRAME aperture, and to future proof for adding additional apertures later if necessary.
In pysiaf/source_data/FGS , 3 files were modified as follows:
fgs_siaf_alignment.txt -> Added an aperture named V-FRAME with all other parameters set to “0”, except the SciAngles to “None” (following what’s done for J-FRAME).
fgs_siaf_aperture_definition.txt -> Added V-FRAME with exactly the same parameters as J-FRAME
fgs_siaf_ddc_apername_mappint.txt -> Added V-FRAME with exactly the same parameters as J-FRAME