Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Clean Up (Additions) #318

Merged
merged 20 commits into from
Sep 3, 2023

Conversation

mfixstsci
Copy link
Collaborator

@mfixstsci mfixstsci commented Aug 18, 2023

  • Adding pyproject.toml
  • Adding MANIFEST.in

Addresses #313, #307

@mfixstsci mfixstsci changed the title Repo Update (Additions) Repo Clean Up (Additions) Aug 18, 2023
@mfixstsci
Copy link
Collaborator Author

@pllim same here. Something weird happened with the commit history 😓 do you know what could have happened?

@pllim
Copy link

pllim commented Aug 21, 2023

See #317 (comment)

@mfixstsci
Copy link
Collaborator Author

Okay @pllim I performed the rebase and "think" the history looks better now.

@pllim
Copy link

pllim commented Aug 22, 2023

You should enable RTD build for PRs to be sure. See https://docs.readthedocs.io/en/stable/pull-requests.html

@mfixstsci
Copy link
Collaborator Author

Okay @pllim I performed the rebase and "think" the history looks better now.

You should enable RTD build for PRs to be sure. See https://docs.readthedocs.io/en/stable/pull-requests.html

@pllim from what I see, there are successful builds under the webhook tab https://github.com/spacetelescope/pysiaf/settings/hooks/52696936?tab=deliveries I am going to add the check as well.

@pllim
Copy link

pllim commented Aug 23, 2023

there are successful builds under the webhook tab

I cannot access that page. But if you think RTD would build for a PR now, either try to close/reopen and existing PR, or open a new PR to see if it pops up.

@pllim
Copy link

pllim commented Aug 30, 2023

I am going to unwatch this PR. But feel free to ping me again if you have specific questions. Thanks and good luck!

@Witchblade101 Witchblade101 merged commit 22ff2dd into spacetelescope:master Sep 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants