Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resample step to cal_step #295

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Jul 19, 2023

PR #282 missed adding the resample step tocal_step-1.0.0. This PR adds the missing resample keyword.

Checklist

  • Schema changes discussed at RAD Review Board meeting
  • Added entry in CHANGES.rst under the corresponding subsection
  • Updated relevant roman_datamodels utilities and tests
  • Passed romancal regression testing on Jenkins / PLWishMaster. Link: https://plwishmaster.stsci.edu:8081/job/RT/job/romancal/XXX/ This adds a non-required field to cal_step which currently does not exist. Thus this cannot currently create any failures.

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 19, 2023 15:23
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a9203cf) 94.24% compared to head (0637b72) 94.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files           4        4           
  Lines         139      139           
=======================================
  Hits          131      131           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit 8276e6c into spacetelescope:main Jul 20, 2023
12 checks passed
@WilliamJamieson WilliamJamieson deleted the feature/calstep_resample branch July 20, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants