Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOT: Changelog check has moved #299

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jul 26, 2023

Changelog check has moved upstream to Scientific Python. Trust me because I am the original author of the bot and I moved it during Scipy 2023 conference.

xref scientific-python/action-check-changelogfile#4

Checklist

Your checklist is irrelevant here. This does not need a change log (otherwise it would be too meta).

upstream to Scientific Python
@pllim pllim requested review from a team and WilliamJamieson as code owners July 26, 2023 18:11
@@ -92,4 +92,3 @@ installed too:
Need other useful packages in your development environment?

pip install ipython pytest-xdist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I didn't touch this file at all.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like #298 was merged even though it was failing the pre-commit.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e95fe61) 95.32% compared to head (fc7b446) 95.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files           4        4           
  Lines         171      171           
=======================================
  Hits          163      163           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pllim added a commit to pllim/roman_datamodels that referenced this pull request Jul 26, 2023
pllim added a commit to pllim/romancal that referenced this pull request Jul 26, 2023
pllim added a commit to pllim/asdf that referenced this pull request Jul 26, 2023
@WilliamJamieson WilliamJamieson merged commit 81d8ac0 into spacetelescope:main Jul 26, 2023
12 of 13 checks passed
@pllim pllim deleted the patch-1 branch July 26, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants