Add missing unit enforcements #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
requested review from
kdupriestsci,
jbrookens and
a team
as code owners
WilliamJamieson
force-pushed
the
bugfix/missing_units
branch
from
3142dcc
to
4cece4d
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 4 4
Lines 171 171
=======================================
Hits 163 163
Misses 8 8 ☔ View full report in Codecov by Sentry. |
WilliamJamieson
force-pushed
the
bugfix/missing_units
branch
from
4cece4d
to
0d67f63
Compare
WilliamJamieson
commented
Jul 27, 2023
Comment on lines
+14
to
+15
| datatype: | ||
| enum: ["float64"] |
There was a problem hiding this comment.
@PaulHuwe should we enforce datatype?
There was a problem hiding this comment.
I like the notion, but I am concerned about it being overly restrictive (floats32 vs 64, etc.)
There was a problem hiding this comment.
We can always just change this or add alternates
kdupriestsci
approved these changes
Jul 31, 2023
WilliamJamieson
force-pushed
the
bugfix/missing_units
branch
from
374cf76
to
bc1b9a2
Compare
4 tasks
WilliamJamieson
force-pushed
the
bugfix/missing_units
branch
from
e056a29
to
3349e1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds enforcement of the units specified by descriptions of keywords, but which were not enforced by the schemas.
closes #268
Checklist
CHANGES.rstunder the corresponding subsection