-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing unit enforcements #300
Add missing unit enforcements #300
Conversation
3142dcc
to
4cece4d
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 4 4
Lines 171 171
=======================================
Hits 163 163
Misses 8 8 ☔ View full report in Codecov by Sentry. |
4cece4d
to
0d67f63
Compare
datatype: | ||
enum: ["float64"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PaulHuwe should we enforce datatype?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the notion, but I am concerned about it being overly restrictive (floats32 vs 64, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can always just change this or add alternates
374cf76
to
bc1b9a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e056a29
to
3349e1f
Compare
This PR adds enforcement of the units specified by descriptions of keywords, but which were not enforced by the schemas.
closes #268
Checklist
CHANGES.rst
under the corresponding subsection