Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Updates for release 0.18. #337

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented Nov 3, 2023

Resolves RAD-nnnn

Closes #

This PR addresses schema changes needed for release 0.18.

  • Adding new Dark keywords to the required list.
  • Removed the truncated keyword from the GuideWindow table.

Checklist

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@PaulHuwe PaulHuwe marked this pull request as ready for review November 3, 2023 01:57
Copy link
Collaborator

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of spurious change which have made it into this PR. If we want these as part of the 0.18 release, then they should be placed in a separate PR which is merged prior to this one.

@PaulHuwe PaulHuwe changed the title Updates for release 0.18. Misc Updates for release 0.18. Nov 6, 2023
@PaulHuwe PaulHuwe merged commit 01fa8d0 into spacetelescope:main Nov 6, 2023
11 checks passed
Copy link
Collaborator

@kdupriestsci kdupriestsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants