Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the schemas and make them compatible with a code generator #350

Conversation

WilliamJamieson
Copy link
Collaborator

This PR addresses some major clean-ups of the RAD schemas as well as some minor changes to them in order to support
automatic python code generation from them.

Highlighted changes:

  • The rad_schema-1.0.0, which is the meta-schema for rad, has been moved out of the schemas directory into its own directory. This is because its not really a "schema" is a schema for the schemas and so it confuses the generator.
  • The tagged_scalars have been moved back into basic-1.0.0 directly. This is effectively reverting RAD-71 Move archive information to be in tags #153. The code generator has methods to overcome the limitations that caused this change.
  • All $ref have been updated to use absolute references via the schema uri specified for each schema (its id) instead of the mix of relative references. Having a single-consistent reference system makes things much simpler.
  • All data_product (top-level non-reference file data model schemas) have been moved into their own directory. This makes the meaning of these schemas much clearer.
  • Move ref_common, ref_exposure_type, and ref_optical_element out of reference_files into the main directory. This is so that reference_files only contains top-level schemas describing the reference files.

Checklist

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@269b368). Click here to learn what that means.

❗ Current head 00711ab differs from pull request most recent head 4d89f76. Consider uploading reports for the commit 4d89f76 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage        ?   95.32%           
=======================================
  Files           ?        4           
  Lines           ?      171           
  Branches        ?        0           
=======================================
  Hits            ?      163           
  Misses          ?        8           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant