Clean up the schemas and make them compatible with a code generator #350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some major clean-ups of the RAD schemas as well as some minor changes to them in order to support
automatic python code generation from them.
Highlighted changes:
rad_schema-1.0.0
, which is the meta-schema for rad, has been moved out of the schemas directory into its own directory. This is because its not really a "schema" is a schema for the schemas and so it confuses the generator.tagged_scalars
have been moved back intobasic-1.0.0
directly. This is effectively reverting RAD-71 Move archive information to be in tags #153. The code generator has methods to overcome the limitations that caused this change.$ref
have been updated to use absolute references via the schema uri specified for each schema (itsid
) instead of the mix of relative references. Having a single-consistent reference system makes things much simpler.data_product
(top-level non-reference file data model schemas) have been moved into their own directory. This makes the meaning of these schemas much clearer.ref_common
,ref_exposure_type
, andref_optical_element
out ofreference_files
into the main directory. This is so thatreference_files
only contains top-level schemas describing the reference files.Checklist
CHANGES.rst
under the corresponding subsection