RAD-143, RAD-144: Add FPS and TVAC schemas #364
Conversation
WilliamJamieson
force-pushed
the
feature/fps
branch
from
e56c3ef
to
c775ebb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 4 4
Lines 195 195
=======================================
Hits 186 186
Misses 9 9 ☔ View full report in Codecov by Sentry. |
WilliamJamieson
force-pushed
the
feature/fps
branch
from
c775ebb
to
1b910dc
Compare
WilliamJamieson
requested review from
kdupriestsci,
jbrookens and
a team
as code owners
WilliamJamieson
force-pushed
the
feature/fps
branch
3 times, most recently
from
a32c24f
to
7bee036
Compare
|
Someone needs to go through all the |
Re group <-> resultant changes, I have mixed feelings. We do want to move from the "group" language to the "resultant" language, but we also want TVAC / FPS to be consistent with the main schemas, and more generally things like groupgap, ngroups we just want to delete as redundant and inflexible as compared with read_pattern. Eventually we need to revisit the L2 metadata to achieve that, but we have not yet. So while we could change the language here I don't think we need to. |
These are being changed in the main schemas as well, in PR #361 |
WilliamJamieson
force-pushed
the
feature/fps
branch
from
9dd61b7
to
c5d030c
Compare
| tag: tag:stsci.edu:asdf/unit/unit-1.* | ||
| enum: ["A"] | ||
| archive_catalog: | ||
| datatype: float |
There was a problem hiding this comment.
No, if you look at it, its a scalar quantity, see line 67. The enum: ["A"] is specifying the unit on the quantity. It is my understanding that archive just stores the numerical value for these.
| tag: tag:stsci.edu:asdf/unit/unit-1.* | ||
| enum: ["A"] | ||
| archive_catalog: | ||
| datatype: float |
There was a problem hiding this comment.
See above comment
WilliamJamieson
force-pushed
the
feature/fps
branch
from
5a0cc1e
to
4668d68
Compare
| @@ -12,105 +12,105 @@ properties: | |||
| enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE'] | |||
| archive_catalog: | |||
| datatype: nvarchar(15) | |||
| destination: [ScienceRefData.s_assign_wcs, GuideWindow.s_assign_wcs] | |||
| destination: [ScienceRefData.s_assign_wcs, GuideWindow.s_assign_wcs, WFICommon.s_assign_wcs] | |||
There was a problem hiding this comment.
@kdupriestsci Not related to this PR, only for my understanding - do we need GuideWindow table updates for the cal_step entries if we are not processing Guide windows?
There was a problem hiding this comment.
I am not the correct person to ask. Maybe @tddesjardins can weigh in?
| %YAML 1.1 | ||
| --- | ||
| $schema: asdf://stsci.edu/datamodels/roman/schemas/rad_schema-1.0.0 | ||
| id: asdf://stsci.edu/datamodels/roman/schemas/ground_exposure-1.0.0 |
There was a problem hiding this comment.
@tddesjardins @fjaviersanchez William's suggestion seems reasonable to me. Any objections?
| %YAML 1.1 | ||
| --- | ||
| $schema: asdf://stsci.edu/datamodels/roman/schemas/rad_schema-1.0.0 | ||
| id: asdf://stsci.edu/datamodels/roman/schemas/ground_guidestar-1.0.0 |
There was a problem hiding this comment.
@tddesjardins @fjaviersanchez William's suggestion seems reasonable to me. Any objections?
| archive_catalog: | ||
| datatype: float | ||
| destination: [WFITvac.wfi_sce_1_vbiasgate_v] | ||
| wfi_sce_1_vbiaspwr_i: |
| archive_catalog: | ||
| datatype: float | ||
| destination: [WFITvac.wfi_sce_1_vbiaspwr_i] | ||
| wfi_sce_1_vbiaspwr_v: |
| archive_catalog: | ||
| datatype: float | ||
| destination: [WFITvac.wfi_sce_1_vbiaspwr_v] | ||
| wfi_sce_1_vreset_v: |
| archive_catalog: | ||
| datatype: float | ||
| destination: [WFITvac.wfi_sce_1_vreset_v] | ||
| wfi_sce_1_vreset_i: |
Resolves RAD-143
Resolves RAD-144
Closes #355 and closes #356
This PR adds the FPS and TVAC data schemas to rad.
Checklist
CHANGES.rstunder the corresponding subsection