Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve all the inverse linearity issues. #248

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Jul 20, 2023

This PR addresses the bugs introduced by spacetelescope/rad#296 into roman_datamodels.

Checklist

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7b5f02f) 96.74% compared to head (eb51950) 96.75%.

❗ Current head eb51950 differs from pull request most recent head 2313f0d. Consider uploading reports for the commit 2313f0d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   96.74%   96.75%           
=======================================
  Files          29       29           
  Lines        2398     2405    +7     
=======================================
+ Hits         2320     2327    +7     
  Misses         78       78           
Impacted Files Coverage Δ
src/roman_datamodels/datamodels/_datamodels.py 91.02% <100.00%> (ø)
src/roman_datamodels/maker_utils/_ref_files.py 95.62% <100.00%> (ø)
src/roman_datamodels/stnode/_node.py 88.75% <100.00%> (+0.14%) ⬆️
tests/test_models.py 100.00% <100.00%> (ø)
tests/test_stnode.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson marked this pull request as ready for review July 20, 2023 18:11
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 20, 2023 18:11
@WilliamJamieson WilliamJamieson merged commit 6080b6d into spacetelescope:main Jul 20, 2023
15 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/crds_inverse_linearity branch July 20, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants