Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev testing #312

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

This PR fixes the dev testing issues caused by not having an "up-to-date" pyerfa library.

Checklist

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9402e53) 97.16% compared to head (9cf1689) 97.48%.
Report is 1 commits behind head on main.

❗ Current head 9cf1689 differs from pull request most recent head c238477. Consider uploading reports for the commit c238477 to get more accurate results

Files Patch % Lines
src/roman_datamodels/datamodels/_datamodels.py 89.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   97.16%   97.48%   +0.32%     
==========================================
  Files          28       29       +1     
  Lines        2542     2709     +167     
==========================================
+ Hits         2470     2641     +171     
+ Misses         72       68       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson WilliamJamieson marked this pull request as ready for review February 5, 2024 16:57
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner February 5, 2024 16:57
@PaulHuwe
Copy link
Collaborator

PaulHuwe commented Feb 5, 2024

Do you have a regression test link for this, or are there expected to be changes in RCAL as well?

@WilliamJamieson
Copy link
Collaborator Author

This shouldn't effect RCAL but I'll run them to be sure.

@WilliamJamieson
Copy link
Collaborator Author

@WilliamJamieson WilliamJamieson merged commit b398edb into spacetelescope:main Feb 5, 2024
17 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/dev_tests branch February 5, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Weekly CI Run the weekly scheduled CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants