Add Source Catalog Model #317
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 97.56% 97.60% +0.04%
==========================================
Files 30 31 +1
Lines 2788 2839 +51
==========================================
+ Hits 2720 2771 +51
Misses 68 68 ☔ View full report in Codecov by Sentry. |
tests/test_models.py
Outdated
There was a problem hiding this comment.
Thanks @WilliamJamieson!
bmorris3
force-pushed
the
source-catalog
branch
from
3c07c6a to
17fb6cf
Compare
bmorris3
force-pushed
the
source-catalog
branch
from
17fb6cf to
889cbde
Compare
bmorris3
force-pushed
the
source-catalog
branch
2 times, most recently
from
d2713e4 to
b161e74
Compare
tests/test_open.py
Outdated
| if node_class == stnode.SourceCatalog: | ||
| pytest.xfail("SourceCatalog does not have a meta attribute yet") | ||
|
|
There was a problem hiding this comment.
Looks like your wanting to include a meta attribute in SourceCatalog if this is the case, update your schemas to include that and remove this change. I think that will fix many of the issues.
There was a problem hiding this comment.
It seems like there's some uncertainty on whether or not to include it, and definitely uncertainty on what that meta should contain. I got the tests passing for now, but I agree that this bit may be unnecessary now.
| return save_node(source_catalog, filepath=filepath) | ||
|
|
||
|
|
||
| def mk_segmentation_map(*, filepath=None, shape=(4096, 4096), **kwargs): |
There was a problem hiding this comment.
Is the segmentation map going to be a data model in its own right?
bmorris3
force-pushed
the
source-catalog
branch
2 times, most recently
from
2bd8bf6 to
cdbaa77
Compare
bmorris3
force-pushed
the
source-catalog
branch
from
ec24d40 to
2756188
Compare
for more information, see https://pre-commit.ci
|
Superseded by #331 |
(work in progress)
This PR implements exposes a model class for the output from the Source Catalog Step. The schema is defined in spacetelescope/rad#374, and the step is being developed in spacetelescope/romancal#1102.
The tests will fail until spacetelescope/rad#374 is merged.
Checklist
CHANGES.rstunder the corresponding subsection