Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip QTables in individual image metadata. #349

Merged
merged 2 commits into from
May 7, 2024

Conversation

schlafly
Copy link
Collaborator

@schlafly schlafly commented May 7, 2024

This PR adds QTable to the list of things to skip for the individual image metadata.

QTables get made as part of the PSF catalog that is now the tweakreg_catalog, instead of the old ndarray.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.09%. Comparing base (087a60d) to head (1bcce9c).
Report is 18 commits behind head on main.

Files Patch % Lines
src/roman_datamodels/datamodels/_datamodels.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   97.56%   97.09%   -0.47%     
==========================================
  Files          30       31       +1     
  Lines        2788     3063     +275     
==========================================
+ Hits         2720     2974     +254     
- Misses         68       89      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator Author

schlafly commented May 7, 2024

@PaulHuwe , I needed this in order to get the IIM to work with the new astropy Table PSF catalogs. Because those are now an astropy table rather than an ndarray the special casing in IIM was not catching them. Any objection to merging this? I think this is the only roman_datamodels update needed.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Update the change log, please.

@schlafly schlafly marked this pull request as ready for review May 7, 2024 18:19
@schlafly schlafly requested a review from a team as a code owner May 7, 2024 18:19
@PaulHuwe PaulHuwe merged commit cc61d85 into spacetelescope:main May 7, 2024
14 of 16 checks passed
@PaulHuwe
Copy link
Collaborator

PaulHuwe commented May 7, 2024

Merging.

@nden nden added this to the 24Q3_B14 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants