-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for reference file unit removal #408
base: main
Are you sure you want to change the base?
Fixes for reference file unit removal #408
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
==========================================
- Coverage 97.56% 97.20% -0.36%
==========================================
Files 30 37 +7
Lines 2788 3289 +501
==========================================
+ Hits 2720 3197 +477
- Misses 68 92 +24 ☔ View full report in Codecov by Sentry. |
388cc73
to
1543f19
Compare
1543f19
to
212a7bf
Compare
Is there a matching RCAL ticket, or does this just necessitate regression file updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves RCAL-nnnn
Closes #
This PR makes
roman_datamodels
compatible with the reference file unit removals in spacetelescope/rad#490.Tasks
roman_datamodels
tests.docs/
page.no-changelog-entry-needed
.)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types).romancal
regression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>"
).News fragment change types:
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.misc.rst
: infrastructure or miscellaneous change